Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update default prover url #158

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

Ondkloss
Copy link
Contributor

@Ondkloss Ondkloss commented Mar 4, 2024

The ZKPool URL no longer includes the port. Update to remove port.

Reference: https://docs.zkpool.io/guides/how-to-connect-ZKPool/

Summary by CodeRabbit

  • Refactor
    • Updated the default prover URL to enhance connectivity and performance.

Copy link

coderabbitai bot commented Mar 4, 2024

Walkthrough

The modification involves a simple yet crucial update to the configuration of a service URL within a Rust project. Specifically, the DEFAULT_PROVER_URL constant's value has been altered to exclude the port number, streamlining the URL format. This change could reflect an infrastructure update or a move towards a more standardized URL access method for the service.

Changes

File Path Change Summary
.../stn/src/constants.rs Updated DEFAULT_PROVER_URL to remove port number.

🐇📜✨
In the realm of code, where constants lie,
A small change makes a big leap, under the sky.
From port-filled paths to a cleaner spree,
A rabbit hopped, with joy and glee.
"To simpler URLs we bound," it said,
As into the sunset, it swiftly sped.
🌅🚀🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 51089c3 and c7d8232.
Files selected for processing (1)
  • crates/stn/src/constants.rs (1 hunks)
Additional comments: 1
crates/stn/src/constants.rs (1)
  • 6-6: The update to the DEFAULT_PROVER_URL constant, removing the port number, aligns with the PR's objective and the changes in the ZKPool service's URL format. This change seems straightforward and should not introduce any issues on its own. However, it's crucial to ensure that all parts of the codebase that rely on this constant are compatible with the new URL format.

Please verify that all usages of DEFAULT_PROVER_URL throughout the codebase have been reviewed to ensure they function correctly with the updated URL, considering the removal of the port number.

@d1onys1us
Copy link
Collaborator

thanks!

@d1onys1us d1onys1us enabled auto-merge (squash) March 4, 2024 22:13
@d1onys1us d1onys1us disabled auto-merge March 4, 2024 22:13
@d1onys1us d1onys1us merged commit 4279384 into libreth:main Mar 4, 2024
7 checks passed
@d1onys1us d1onys1us mentioned this pull request Feb 23, 2024
@d1onys1us d1onys1us mentioned this pull request Mar 13, 2024
This was referenced May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants