Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Removing Limit From Query Interface #230

Closed
jrduncans opened this issue Apr 10, 2022 · 4 comments
Closed

Consider Removing Limit From Query Interface #230

jrduncans opened this issue Apr 10, 2022 · 4 comments

Comments

@jrduncans
Copy link
Contributor

Limit is an optional parameter to the Query API: https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_Query.html#DDB-Query-request-Limit

When not sent, AWS automatically limits the data to around 1MB. Being forced to pick a value to exceed that amount adds friction to using the API. Since Meteor automatically pages through using lastEvaluatedKey, setting a limit doesn't seem to be of value, as it doesn't limit how many records Meteor returns, just the size of a batch.

@d2a4u
Copy link
Owner

d2a4u commented Apr 21, 2022

That sounds good to me. It would be amazing if you can raise a PR to remove limit parameter

@jrduncans
Copy link
Contributor Author

Ok, I've got two branches, let me know which one you'd prefer as the PR:

@d2a4u
Copy link
Owner

d2a4u commented May 6, 2022

Hi, sorry for late reply. My laptop is dead and getting a new one is quite difficult atm. Deprecation branch looks good to me. Thanks

@jrduncans
Copy link
Contributor Author

Closed in #240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants