-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the @testing-library/react
dependency
#940
Comments
I've updated the version but it showing some errors while I'm doing the commit. |
Hey @Yasir761 what kind of errors do you see? |
.storybook/docs/components/WelcomeBanner.tsx(3,32): error TS2307: Cannot find module '../../../packages/design-tokens/build/js/designTokens' or its corresponding type declarations. |
@Yasir761 Could you double-check that you've run You can run |
@nataliepina Yes, I was able to start the storybook and also did some debugging but, it still the giving same output. |
I see the issue here @Yasir761. We have commit message linting. You will need to prefix your commit message with a commit type. For example Let me know if you're still having issues with committing after that! |
@nataliepina , It still shows the same message. |
Could you review the steps to contribute one last time and make sure you've completed each step? You should be able to commit this after a I have tested it out with those commands and here is a successful flow: |
Judging by the errors it looks like you have something extra that needs to be deleted that is throwing off the formatting. These errors are triggered by Prettier which we use to format the code. Try to run If all of that fails, you may want to remove your changes altogether and try again. Or look over the changes and compare the differences to see if there is an extra character or something formatted incorrectly. An overview of the changes to implement the new version:
|
Hi @Yasir761 were you able to resolve the issues and able to commit? Please let us know if you're still encountering anything else with that. |
I try everything but don't know why it is showing same error to me |
I'm sorry you're encountering problems with this! I'm going to attempt this update again to make sure there aren't any problems on our end, and I will update it if all goes well. For that reason, I will close this issue out. We should be adding more issues here soon if you'd like another opportunity to contribute. Thanks for your interest! |
Description
We are a major version behind on React Testing Library. Update the dependency to the latest version -> 14.0.0. If there are any issue with our unit tests, please fix them.
@testing-library/react 13.4.0 → 14.0.0
Contribution Guide
Please review the How to Contribute guide beforehand.
The text was updated successfully, but these errors were encountered: