Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vol2 hpo #2372

Merged
merged 323 commits into from Dec 9, 2022
Merged

Vol2 hpo #2372

merged 323 commits into from Dec 9, 2022

Conversation

aaronkl
Copy link
Contributor

@aaronkl aaronkl commented Dec 5, 2022

Description of changes:

Add initial set of notebooks for the HPO chapter: index, intro, api, hyperband, async RS, async SH.

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

@d2l-bot
Copy link
Member

d2l-bot commented Dec 8, 2022

Job d2l-en/PR-2372/61 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2372/

@d2l-bot
Copy link
Member

d2l-bot commented Dec 9, 2022

Job d2l-en/PR-2372/62 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2372/

@mseeger
Copy link
Contributor

mseeger commented Dec 9, 2022

OK, I am signing off. This should go through now, and if not, nothing I can do

@d2l-bot
Copy link
Member

d2l-bot commented Dec 9, 2022

Job d2l-en/PR-2372/63 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2372/

@d2l-bot
Copy link
Member

d2l-bot commented Dec 9, 2022

Job d2l-en/PR-2372/64 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2372/

@d2l-bot
Copy link
Member

d2l-bot commented Dec 9, 2022

Job d2l-en/PR-2372/65 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2372/

@d2l-bot
Copy link
Member

d2l-bot commented Dec 9, 2022

Job d2l-en/PR-2372/66 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2372/

@d2l-bot
Copy link
Member

d2l-bot commented Dec 9, 2022

Job d2l-en/PR-2372/67 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2372/

@d2l-bot
Copy link
Member

d2l-bot commented Dec 9, 2022

Job d2l-en/PR-2372/69 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2372/

@d2l-bot
Copy link
Member

d2l-bot commented Dec 9, 2022

Job d2l-en/PR-2372/71 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2372/

@d2l-bot
Copy link
Member

d2l-bot commented Dec 9, 2022

Job d2l-en/PR-2372/72 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2372/

@astonzhang
Copy link
Member

Thanks for all your amazing work! To save everyone's time I've added my edits directly on the PR. In the future (including the following TODO), please raise PR directly on the master branch.

TODO @mseeger (by EOD today. Time estimation: ~15 mins)

For each notebook: please create a discussion post under category "English Version - pytorch" (you'll need to sign up an account) at https://discuss.d2l.ai/c/english-version/5 and add that post at the end of the corresponding notebook

Example:

At the end of https://raw.githubusercontent.com/d2l-ai/d2l-en/master/chapter_linear-classification/softmax-regression-scratch.md

we add (plz remove the [topic name] in the URL: discuss.d2l.ai/t/[topic name]/[topic id] -> discuss.d2l.ai/t/[topic id])

:begin_tab:`pytorch`
[Discussions](https://discuss.d2l.ai/t/51)
:end_tab:

where https://discuss.d2l.ai/t/softmax-regression-implementation-from-scratch/51 was created correspondingly

TODOs @aaronkl (next week if possible)

  • Add exercises for every notebook
  • Fig 19.3.1, 19.5.1, 19.5.2: Apply correct font size in https://github.com/d2l-ai/d2l-en/blob/master/STYLE_GUIDE.md#figure. Use transparent background. Upload graffle files to graffle/hpo/ on d2l-en repo.
  • Need more space efficient display of tuner.run() output INFO:XXX in rs-async and sh-async, and tuner.run(number_of_trials=30) output plots in sh-intro
  • sh.svg cannot display properly in html so I used sh.png tentatively. We'll still need svg for this figure (need to troubleshoot).

@astonzhang astonzhang merged commit 4c716b8 into d2l-ai:vol2-hpo Dec 9, 2022
@mseeger
Copy link
Contributor

mseeger commented Dec 9, 2022

Somehow, I cannot sign up for an account for comments. Says that there were too many accesses from my IP address?

@AnirudhDagar
Copy link
Member

Weird! Can you please try with your mobile network?

@mseeger
Copy link
Contributor

mseeger commented Dec 9, 2022

OK, I have an account. I suppose I need to create a separate discussion topic for each section?
I posted one, but it needs to be reviewed. When trying to post another one, the system blocked me.

Leaving this for later.

@AnirudhDagar
Copy link
Member

Approved!

@mseeger
Copy link
Contributor

mseeger commented Dec 9, 2022

OK, I created 4 topics, but now I am blocked again. How urgent is this?

I created a new branch, which does two things:

  • Reduce log output for tuner.run()
  • Add these discussion things at the end (except for one notebook)

Do you want me to create a PR with this now, or can this wait until I maybe thought about some exercises?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants