Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Minor code cleaning.
The
[None, :]
is unnecessary, because without[None, :]
PyTorch broadcasting will also prepend 1 to the dimensions of torch.arange()'s output.I tested the change by removing the
[None, :]
and running themasked_softmax()
code below in 11.3.2.1.The output are the same as when we have
[None, :]
, in terms of the numbers of masked and unmasked elements.I pasted the output below. You can compare it with the output on the website.
By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.