Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brush loses functionality if mouseup occurs outside frame #39

Closed
rbwest opened this issue Nov 9, 2018 · 1 comment
Closed

Brush loses functionality if mouseup occurs outside frame #39

rbwest opened this issue Nov 9, 2018 · 1 comment

Comments

@rbwest
Copy link

rbwest commented Nov 9, 2018

Typically clicking on a brush context results creates an "end" event with a null selection. When these conditions are seen the brush can be re-initialized to the entire range of the context area as is done in this example.

If a brush event is started but the user releases the mouse outside of the frame, then the brush event will still be going on when the user mouses back into the frame. The user then must click to end the brush event, but in doing so the brush selection rect disappears.

At this point clicking the brush context will no longer create an "end" event with a null selection to reset the brush selection to the entire range of the context area.

@mbostock
Copy link
Member

mbostock commented Aug 2, 2019

Thanks for the report. This sounds like a duplicate of #18, plus the general weirdness of how events work in the context of frames. For the latter, see d3/d3-drag#9 for discussion.

@mbostock mbostock closed this as completed Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants