Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FF android #76

Open
Fil opened this issue Aug 24, 2020 · 2 comments
Open

FF android #76

Fil opened this issue Aug 24, 2020 · 2 comments

Comments

@Fil
Copy link
Member

Fil commented Aug 24, 2020 •
edited

on ff android vertical pan is a little janky - address bar keeps moving up and down.
Same in v1 - not a regression or anything

(reported by @1wheel)
@Fil
Copy link
Member Author

Fil commented Aug 25, 2020

Maybe a case of touch-action: none or touchStart.preventDefault ; see https://observablehq.com/d/8c6133113d33b60c

@Fil
Copy link
Member Author

Fil commented Aug 26, 2020

tested on an Android phone this version seems good (fixing the issue both on Chrome and FF):

the difference is svg.on("touchstart", event => event.preventDefault())

I'm not sure if it should be added by default in d3-brush or left to the user.

@Fil Fil mentioned this issue Sep 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Fil