Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix beveling on canvas edges. #4

Closed
mbostock opened this issue Apr 7, 2017 · 2 comments
Closed

Fix beveling on canvas edges. #4

mbostock opened this issue Apr 7, 2017 · 2 comments

Comments

@mbostock
Copy link
Member

mbostock commented Apr 7, 2017

image

I think we need to special-case the segments that are added on the canvas edges, rather than treating it as if the virtual pixels surrounding the canvas were always excluded from the contour.

@mbostock
Copy link
Member Author

mbostock commented Nov 5, 2017

Unfortunately I think the only solution here is to overdraw. Even if you use straight edges rather than bevels, it’s still not correct when smoothing enabled—you need the additional information from outside the displayed grid.

@Fil
Copy link
Member

Fil commented Jun 24, 2020

Closing due to inactivity (and no solution, even in theory!)

@Fil Fil closed this as completed Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants