Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename drag.subject to drag.data? #17

Closed
mbostock opened this issue May 16, 2016 · 2 comments
Closed

Rename drag.subject to drag.data? #17

mbostock opened this issue May 16, 2016 · 2 comments
Assignees

Comments

@mbostock
Copy link
Member

mbostock commented May 16, 2016

The word subject implies it’s the thing doing the dragging, not the thing being dragged. We could use the word object, but I think data would be better.

Or not. Subject is defined as “a person or thing that is being discussed, described, or dealt with.” Which could be appropriate.

@mbostock mbostock self-assigned this May 16, 2016
@mbostock mbostock changed the title Rename drag.subject to drag.data. Rename drag.subject to drag.data? May 16, 2016
@altocumulus
Copy link

When first running into subject, I intuitively got it right. I'd prefer subject over data or object.

@mbostock
Copy link
Member Author

Yeah, it’s probably fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants