Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t ignore NaN parameters? #7

Closed
mbostock opened this issue Nov 19, 2015 · 2 comments
Closed

Don’t ignore NaN parameters? #7

mbostock opened this issue Nov 19, 2015 · 2 comments
Assignees
@mbostock

Comments

@mbostock
Copy link
Member

We currently ignore null, undefined and NaN easing parameters. I understand why we should ignore null and undefined, but ignoring NaN seems unnecessary. (I suppose it’s consistent with how d3-arrays ignores values, though.)
@mbostock mbostock changed the title Don’t ignore NaN parameters. Don’t ignore NaN parameters? Nov 19, 2015
@mbostock
Copy link
Member Author

The problem with ignoring NaN here is it suggests we should ignore NaN everywhere, which is burdensome and of dubious value. In d3-shape, for example, I ignore null and undefined interpolation parameters, but not NaN ones.

@mbostock mbostock self-assigned this Nov 21, 2015
@mbostock
Copy link
Member Author

Fixed in 0.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbostock mbostock

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbostock