Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom bundle via rollup is broken #28

Closed
Turbo87 opened this issue Sep 21, 2016 · 1 comment
Closed

Custom bundle via rollup is broken #28

Turbo87 opened this issue Sep 21, 2016 · 1 comment

Comments

@Turbo87
Copy link

Turbo87 commented Sep 21, 2016

I'm trying to generate a custom bundle of D3 v4 using rollup:

https://github.com/Turbo87/rollup-d3-issue

Running npm run build (or rollup -c) will produce a bundled file at dist/d3.js which looks fine on first glance. It includes the following function call:

defaultLocale({
  decimal: ".",
  thousands: ",",
  grouping: [3],
  currency: ["$", ""]
});

but the defaultLocale() function is not defined anywhere in the bundle even though it's in the original code (at https://github.com/d3/d3-format/blob/v1.0.2/src/defaultLocale.js).

Note that if I add export { formatDefaultLocale } from 'd3-format'; to the d3.js file we can work around this issue. This is not a good long-term solution though.

Cross-posted this as rollup/rollup#970

@mbostock
Copy link
Member

Thanks for filing an issue. This is clearly a Rollup bug, so I’ll close this and reply over there if I have any insight. Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants