We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
South aspect of Lee’s conformal projection in a tetrahedron shows all black.
From the tweet exchange @Fil has verified that
it doesn't happen with d3-geo-polygon@1.7 but with d3-geo-polygon@1.8
The text was updated successfully, but these errors were encountered:
Ref: https://observablehq.com/@fil/lee-projection (which I momentarily “fixed” by going back to d3-geo-polygon@1.7).
Sorry, something went wrong.
the bad commit is eb1e663 (of course)
There is this quick test in https://github.com/d3/d3-geo-polygon/blob/master/src/intersect.js#L19 : two arcs of angles a.l and b.l can not intersect if the distance between start (or end) of the first and the start (or end) of the second make an angle > a.l + b.l.
I optimized it with the acos of the angles and forgot that, if A+B > pi, the cosine increases again. Fix and test incoming.
v1.8.1
3ef8487
fix geoTetrahedralLeeSouth #28
you are a wizard! well done and thanks
No branches or pull requests
South aspect of Lee’s conformal projection in a tetrahedron shows all black.
From the tweet exchange @Fil has verified that
The text was updated successfully, but these errors were encountered: