Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are es2015 in the final package file #183

Closed
zhubin1992 opened this issue Jan 3, 2020 · 3 comments
Closed

There are es2015 in the final package file #183

zhubin1992 opened this issue Jan 3, 2020 · 3 comments

Comments

@zhubin1992
Copy link

d3-geo-projection@2.8.0/dist/d3-geo-projection.js (:445)

function solve2d(f, MAX_ITERATIONS = 40, eps = epsilon2) {
  return function(x, y, a = 0, b = 0) {
    ...
  };
}

Default function parameters are ECMAScript 2015.That will cause some errors.

@zhubin1992
Copy link
Author

We need use Babel to use the latest JavaScript features that aren't yet supported by browsers and Node.js.

@Fil Fil closed this as completed in 06b2add Jan 3, 2020
@Fil
Copy link
Member

Fil commented Jan 3, 2020

My mistake. I always forget. Thank you!

@mbostock
Copy link
Member

mbostock commented Jan 6, 2020

You can add an eslint rule to remind you if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants