Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d3.geoProjection #27

Closed
5 tasks done
mbostock opened this issue Jun 16, 2016 · 3 comments
Closed
5 tasks done

d3.geoProjection #27

mbostock opened this issue Jun 16, 2016 · 3 comments
Assignees
@mbostock

Comments

@mbostock
Copy link
Member

mbostock commented Jun 16, 2016 •
edited

  • d3.geoProjection
  • projection.clipAngle
  • projection.clipExtent
  • rename projection.stream to projection.sink nah
  • remove sink.valid

See also #33 regarding projection.clipExtent.
@mbostock mbostock mentioned this issue Jun 16, 2016
Closed
4 tasks
@mbostock
Copy link
Member Author

mbostock commented Jun 16, 2016 •
edited

Related #29, the projection.stream method should probably be renamed to projection.sink.

EDIT: Actually this is a little confusing, because then it’s projection.sink(sink). The idea is that you’re taking a sink and wrapping it in a new sink, so that the geometry is transformed (i.e., projected) before being passed to the original sink. So a better name might be projection.transform(sink).

@mbostock mbostock self-assigned this Jun 16, 2016
@mbostock
Copy link
Member Author

It should be possible for the projection to memoize projection.sink(sink), rather than using sink.valid.

mbostock added a commit that referenced this issue Jun 16, 2016
@mbostock
Add d3.geoProjection.
501473f 
Related #27. I haven’t yet ported clipExtent or clipAngle.
@mbostock
Copy link
Member Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbostock mbostock

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbostock