Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d3.geoStream #7

Closed
mbostock opened this issue Mar 3, 2016 · 3 comments
Closed

d3.geoStream #7

mbostock opened this issue Mar 3, 2016 · 3 comments

Comments

@mbostock
Copy link
Member

mbostock commented Mar 3, 2016

https://github.com/mbostock/d3/blob/master/src/geo/stream.js

Needed by d3.geoLength #1 and d3.geoArea #4. Will also be needed by d3-geo-projection.

@chrisuehlinger
Copy link
Contributor

Hey! I'm the guy who expressed interest in helping on Twitter the other night. I'm currently in the process of clearing the Contributor Agreement with my employer (hopefully should be good sometime next week).

In the meantime, I've got a couple questions about how best to help:

  • Are we getting rid of the d3.geo namespace in v4 and just appending "geo" to the names of its members?
  • Do you have any sort of style guide or list of conventions that you use in the d3 codebase? I've looked at d3-selection as an example to follow, but I wasn't sure if you had an actual guide written down somewhere.
  • I'm guessing that a lot of the initial work of this project will involve copying over code (and docs) from d3 and getting the code and tests into line with the tools and conventions you're using in v4. However, I'm also guessing that you have plans for d3-geo beyond simply breaking it out into its own module. Do you have any initial notes or ideas that could guide me while working on this?

I've used d3.geo in a number of projects, I'm looking forward to giving back to this awesome library!

@mbostock
Copy link
Member Author

mbostock commented May 13, 2016

Are we getting rid of the d3.geo namespace in v4 and just appending "geo" to the names of its members?

Yes. For example, d3.geo.stream becomes d3.geoStream. ES6 modules export symbols, so a flat namespace is required.

Do you have any sort of style guide or list of conventions that you use in the d3 codebase?

No, sorry. You’ll have to look at the other repositories to infer the style conventions…

I'm also guessing that you have plans for d3-geo beyond simply breaking it out into its own module.

Yes, but they are probably going to wait until D3 5.0 since I’d like to get D3 4.0 released. The primary idea I’d been pursuing is a modular projection pipeline (example 1, example 2, example 3), rather than our current monolithic projection pipeline. There are a couple optimizations of rotation and clipping in the current pipeline that might be hard to replicate with the modular pipeline (see #2169), but I’m not sure it’s a showstopper.

@mbostock
Copy link
Member Author

Fixed in #9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants