Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should EnterNode implement appendChild and insertBefore? #19

Closed
mbostock opened this issue May 16, 2015 · 2 comments
Closed

Should EnterNode implement appendChild and insertBefore? #19

mbostock opened this issue May 16, 2015 · 2 comments

Comments

@mbostock
Copy link
Member

If EnterNode provided custom implementations of these methods, we wouldn’t need an explicit EnterSelection implementation. But, this would require each EnterNode to have a reference to the group’s parentNode, and for the EnterNode to know which index to set in the update group upon creation. And it would probably prevent enter.select from working…
@mbostock
Copy link
Member Author

Probably not.

@mbostock mbostock mentioned this issue May 22, 2015
Closed
@mbostock
Copy link
Member Author

Probably yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbostock