Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should selection.data modify the enter and exit selections, too? #22

Closed
mbostock opened this issue May 19, 2015 · 1 comment
Closed

Comments

@mbostock
Copy link
Member

Now that selection.data modifies the update selection in-place, wouldn’t it also make sense to modify the enter and exit selections in-place, too (rather than modifying the update selection in-place but creating new enter and exit selections)?

@mbostock
Copy link
Member Author

One downside of modifying in-place is that bad things happen if someone modifies the number of in-place groups. But that shouldn’t happen if the groups array is private.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant