Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

math.js consistency #131

Closed
Fil opened this issue Sep 6, 2018 · 2 comments
Closed

math.js consistency #131

Fil opened this issue Sep 6, 2018 · 2 comments

Comments

@Fil
Copy link
Member

Fil commented Sep 6, 2018

I've checked a lot (maybe all) math.js files in src/ and found two inconsistencies in d3-shape:

  • epsilon = 1e-12 (elsewhere it's 1e-6 and we have epsilon2 = 1e-12)
  • tau = 2 * pi (elsewhere it's pi * 2)

https://beta.observablehq.com/@fil/math
@mbostock
Copy link
Member

Not really sure if we need to do anything here.

@Fil
Copy link
Member Author

Fil commented Aug 10, 2019

I would suggest to rename epsilon as epsilon2 in this module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fil @mbostock