Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documation clarification #144

Closed
nathanhack opened this issue Mar 8, 2019 · 2 comments
Closed

Documation clarification #144

nathanhack opened this issue Mar 8, 2019 · 2 comments

Comments

@nathanhack
Copy link
Contributor

The symbol.size doesn't explicitly say it supports functions with the common element d, index i, and the array data theme found elsewhere.
https://github.com/d3/d3-shape/blob/master/README.md#symbol_size

Is the intent to support it and the documentation just needs to be updated?
or
Is the documation correct and supporting it is a happy coincidence?
(Just trying to make sure I understand which is intended to be supported moving forward).

@mbostock
Copy link
Member

mbostock commented Mar 8, 2019

It’s more precise to say that the size accessor receives whatever arguments you pass the symbol generator (which is typically d, i, nodes if you’re using it with d3-selection). The same goes for the type accessor. If you want to contribute a clarification to the README as a PR that would be great!

@nathanhack
Copy link
Contributor Author

Excellent, thanks for the quick response. PR #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants