Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jsdom? (node 4) #2596

Closed
maxkostow opened this issue Oct 23, 2015 · 3 comments
Closed

Update jsdom? (node 4) #2596

maxkostow opened this issue Oct 23, 2015 · 3 comments
Milestone
4.0

Comments

@maxkostow
Copy link

d3 currently relies on jsdom 3 which uses contextify which doesn't build on node 4. Is there any chance to update to jsdom 4+? It apparently breaks compatibility with node < 4 by relying on a new vm.
@maxkostow maxkostow changed the title Update jsdom? Update jsdom? (node 4) Oct 23, 2015
@mbostock mbostock added the req label Oct 24, 2015
@mbostock mbostock added this to the 4.0 milestone Oct 24, 2015
@mbostock
Copy link
Member

Sucks that there’s no graceful upgrade strategy, but at least JSDOM was recently demoted to a development-only dependency so this only affects a subset of users.

I say we shouldn’t do this for a patch release with 3.5.7, but it seems reasonable to tie this to the 4.0 release.

@mbostock mbostock mentioned this issue Oct 24, 2015
Closed
@mbostock
Copy link
Member

mbostock commented Nov 6, 2015

I’ve upgraded the 4.0 modules to use JSDOM 7.

@mbostock
Copy link
Member

mbostock commented Mar 1, 2016

Fixed in 4.0, which now uses JSDOM 8.

@mbostock mbostock closed this as completed Mar 1, 2016
@jywarren jywarren mentioned this issue Sep 30, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
4.0
Development

No branches or pull requests
2 participants
@mbostock @maxkostow