Update desc of color.toString to match v4 functionality #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Super tiny change in documentation. Looks like the functionality of color.toString changed between v3 and v4. v3 returned hex representation and v4 returns string according to CSS spec. But, this description got missed in the md file. I wasn't sure if you'd prefer "returns string representation of rbg values" or "returns string according to CSS spec" or something else. Mostly just wanted to flag the need for this tweak in the documentation. thanks!
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super tiny change in documentation.
Looks like the functionality of color.toString changed between v3 and v4. v3 returned hex representation and v4 returns string according to CSS spec. But, this description got missed in the md file.
I wasn't sure if you'd prefer "returns string representation of rbg values" or "returns string according to CSS spec" or something else. Mostly just wanted to flag the need for this tweak in the documentation.
thanks!