Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vitepress docs #3654

Merged
merged 107 commits into from Jun 8, 2023
Merged

vitepress docs #3654

merged 107 commits into from Jun 8, 2023

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented May 17, 2023

Fixes #3655.

@mbostock mbostock changed the title checkpoint vitepress docs vitepress docs May 17, 2023
tophtucker and others added 2 commits June 7, 2023 20:22
* Add short "D3 in React" section

I know you removed the TODO but I was already trying to fill it in! I think just making the distinction of modules that touch the DOM and those that don't was super clarifying for me personally when I figured that out. And I always forget the most basic ref pattern (and still might've messed it up here). I don't think we should get into updating or interactivity or whatever, but I think just this much goes a long way toward demystifying (and showing just the most basic best practices).

* forgot i made data generic, rm reference to normal distribution

* useEffect cleans up after itself

Co-authored-by: Mike Bostock <mbostock@gmail.com>

* Update getting-started.md

---------

Co-authored-by: Mike Bostock <mbostock@gmail.com>
@mbostock mbostock marked this pull request as ready for review June 8, 2023 01:07
@mbostock mbostock merged commit 6d6c679 into main Jun 8, 2023
1 check passed
@mbostock mbostock deleted the mbostock/vitepress branch June 8, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

VitePress documentation tracking issue
4 participants