Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for type definition file #2

Open
ankitagarwal299 opened this issue Oct 10, 2018 · 3 comments · May be fixed by #3
Open

Request for type definition file #2

ankitagarwal299 opened this issue Oct 10, 2018 · 3 comments · May be fixed by #3

Comments

@ankitagarwal299
Copy link

Hey Mike,

While importing this module into Typescript file, it is complaining about d.ts file or type definition file not included in the package. I am new to typescript and trying to figure out how to create @types/versor into this package.

image

@clhenrick clhenrick linked a pull request Oct 12, 2018 that will close this issue
@clhenrick
Copy link
Collaborator

@ankitagarwal299 would you try using the branch typescript-defs with your code and seeing if that fixes things for you? I'm using it like so and it seems to catch types:

import versor = require("versor");

const v0 = versor([ 0, 0, 0 ]);
const v1 = versor([ 90, 0, 0 ]);

const delta = versor.delta(v0, v1);

const delta2 = versor.delta(v0, v1, 0.5);

const cartesian = versor.cartesian([-80, 44]);

const rotation = versor.rotation([10, 30, 40, 4]);

const multiply = versor.multiply([10, 20, 30, 40], [0, 20, 30, 50]);

// this fails as it should
versor.delta("a", "b");

// this fails
versor("a");

@clhenrick
Copy link
Collaborator

@ankitagarwal299 have you tried the branch I mentioned earlier? Would be good to get the related PR merged. Thanks!

@nestarz
Copy link

nestarz commented Nov 6, 2019

It is ok for me at least 💃 Would love a PR and a NPM update ;d

But maybe delay it after the interpolate feature landed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants