Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked how reagents cool/heat you. #12468

Closed
wants to merge 1 commit into from
Closed

Reworked how reagents cool/heat you. #12468

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 4, 2016

Or rather, made them cool/heat you at all.
You see, in the past, A glass of ice would be equally good at warming you up as coffee. (That's not how ice works)
Reagents also had no behaviour for cooling and heating, only snowflaked in stuff.
Made T37C a define.
Capsaicin and Frost Oil should not change your temperature to lethal amounts anymore, but instead will cause you minor burn damage to the head and still give you the alert for feeling hot or cold

How it works now: All drinks/reagents move you towards their temperature. By default, all reagents are 37C. - They do so at a rate of:
Their volume times the difference in temperature between that of the person times their heat conductivity times the coefficient (currently: 0.0001)

This means that if you drank 50 units of coffee (60C), you would gain 0.115c extra a tick (0.0001 x 50 x 23)
Alternatively if you drank 50 units of ice (0C), you would lose 0.185c extra a tick.
This should never be lethal (on its own), as hypothermia will kick in and start you shivering and heating up first, and the "hyperthermia" system should be able to prevent all but the most hot of food from killing you

Pending 馃挴 % testing

Or rather, made them cool/heat you at all.
You see, in the past, A glass of ice would be equally good at warming you up as coffee. (That's not how ice works)

Also Made T37C a define.
@@ -2919,36 +2898,16 @@
color = "#B31008" //rgb: 139, 166, 233
data = 1 //Used as a tally
custom_metabolism = FOOD_METABOLISM
temperature = T0C+10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't believe you made cold drinks colder than frost oil.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know hot peppers aren't hot, right? Why should cold peppers be cold

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, spicy food cools your core temperature down, IIRC
Pretty funny

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They do, @kilozombie, by being a vasodilator.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to take the approach that cold peppers merely produce a cold sensation rather than actually having a cold temperature, I might suggest adding some kind of descriptive text to them mentioning that they contain menthol, the compound found in mints that produces a cool sensation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shadowmech88 pshhh menthol what is this

@ghost
Copy link
Author

ghost commented Nov 4, 2016

Testing reveals no major issues, seems fine and dandy, working as intended

@Intigracy Intigracy added the Balance Potentially going to upset people as it changes balance of the game. label Nov 4, 2016
@ghost
Copy link
Author

ghost commented Nov 4, 2016

does this mean taking frost oil for ghetto cryo is dead?

@Intigracy
Copy link
Contributor

Yes

@ghost
Copy link
Author

ghost commented Nov 4, 2016

@whorena That's been the case for a while

@ghost
Copy link
Author

ghost commented Nov 4, 2016

@whorena That dream's been dead for YEARS

Concentrated anti-capsaicin that makes you go to cryo-esque temperatures when?

@SkowronX
Copy link
Contributor

SkowronX commented Nov 4, 2016

Yep. This is definitely how heat transfer works.

@ghost
Copy link
Author

ghost commented Nov 4, 2016

@SkowronX It's better than how it worked before 鈩笍

@@ -3370,7 +3329,6 @@
return 1

M.nutrition += nutriment_factor
M.bodytemperature += 10 * TEMPERATURE_DAMAGE_COEFFICIENT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell Ramen can no longer be used to burn someone to death? 馃憥

That's the whole point of Hell Ramen. If you take that out it's totally identical to Hot Ramen.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gimme a sec, I'll readd that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remind me when you readd that and I'll change my redditvote

Copy link
Contributor

@Intigracy Intigracy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-add hell ramen

@FudgePucker
Copy link
Contributor

I think I am alright with most of the changes. But I do have a problem with chilli not warming you up.

This is YET another nerf to shaft miners. Being able to fix your tempature when facing basklisks is nice.

Also cold sauce being the same as hot sauce in being not a real tempature change doesn't make all that much sense. It is a genetic change using mutagen, so it having mystical cooling powers isn't that bizarre considering other mutations are, litteral golden apples, a plant that grows eggs, and flowers containing moonshine. Realism is off the table when mutagen is involved. A solution could be to add mint plants, it would be a source of mint toxin besides the waver thin mint, and also menthol, which could have phedso cooling. It would be nice to have mint based dishes, including candy canes for the holidays coming up. Also being able to make more bartending drinks. Also being able to dip cigirattes into some menthol to have menthol cigies.

@ghost
Copy link
Author

ghost commented Nov 18, 2016

@FudgePucker Chili still heats you up, though I'm not sure if it's at the same rate, I'll look into it.
Frost oil also cools you.
Both of these chemicals do not do so excessively.
Honestly, shaft miners should carry coffee instead, it's far better at heating you up even before this PR

@vgstation-coders vgstation-coders locked and limited conversation to collaborators Dec 22, 2016
@vgstation-coders vgstation-coders unlocked this conversation Dec 24, 2016
@Probe1
Copy link
Member

Probe1 commented Dec 24, 2016

Wait did this fucking seriously sit open for a month and a half because of HELL RAMEN?

@Kurfursten
Copy link
Collaborator

Kurfursten commented Dec 24, 2016

It's a very important easter egg food

For the record, "a sec" in Celt language is coming up on 50 days in time

@Probe1
Copy link
Member

Probe1 commented Jan 12, 2017

@9600bauds do you wanna clean this PR up or.. close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Potentially going to upset people as it changes balance of the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants