Fixes #5152, Hair selection arrows are bugged #12809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
PJB3005
suggested changes
Dec 18, 2016
| @@ -138,6 +138,32 @@ | |||
| clothes_s.Blend(new /icon('icons/mob/back.dmi', "satchel"), ICON_OVERLAY) | |||
| return clothes_s | |||
|
|
|||
| /datum/preferences/proc/valid_hairstyles(var/gender_restricted = TRUE) | |||
There was a problem hiding this comment.
Why does this one have a gender_restricted parameter, but not the other one?
Also, unify these.
There was a problem hiding this comment.
Because whoever coded this before decided there is no conceivable reason for female characters to ever grow a beard
|
k dun |
|
@PJB3005 get back to this please. |
PJB3005
approved these changes
Dec 30, 2016
ihadtoregisterforthis
pushed a commit
to ihadtoregisterforthis/fork4
that referenced
this pull request
Jul 3, 2017
…ion-coders#12809) * Fixes vgstation-coders#5152, Hair selection arrows are bugged * mirror mirror in the wall * fixes vgstation-coders#12918
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes #9648