Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #11133 #12840

Merged
merged 1 commit into from Dec 17, 2016
Merged

Fixes #11133 #12840

merged 1 commit into from Dec 17, 2016

Conversation

ghost
Copy link

@ghost ghost commented Dec 16, 2016

No description provided.

@Iamgoofball
Copy link
Contributor

holy shit

@Probe1
Copy link
Member

Probe1 commented Dec 16, 2016

HE DOES IT AGAIN THE MAD LAD

@kilozombie
Copy link
Contributor

Just keep this up til 2017 and nobody will be capable of complaining

@ComicIronic
Copy link
Contributor

Why does this even work?

@ghost
Copy link
Author

ghost commented Dec 17, 2016

@ComicIronic qdel(mmi) //Delete the MMI first so that it won't go popping out.
I presume once upon a time this was a del, so it completely deleted it from the game. Before this PR however, it still holds a reference to the GC'd MMI so it spawns that upon the MoMMI dusting despite it being deleted - resulting in an undeletable (because it's already been deleted) MMI

@PJB3005
Copy link
Contributor

PJB3005 commented Dec 17, 2016

And did you actually test it to double check it works?

@ghost
Copy link
Author

ghost commented Dec 17, 2016

@PJB3005 what why would I test this

(Yes)

@ComicIronic ComicIronic merged commit 6bba5d9 into vgstation-coders:Bleeding-Edge Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants