New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #10874, pneumatic cannon cannot be fired by hulks #12952
Conversation
This isn't really a bugfix, because there's nothing to suggest that the pneumatic cannon was specifically intended to not be able to be fired by hulks. |
A good chunk of all the issues in the milestone are [Oversights] like that |
But if you really insist I can do 101 |
I was just speaking from a tagging/merging perspective. |
Too late #12954 |
if ((M_CLUMSY in M.mutations) && prob(50)) | ||
to_chat(M, "<span class='danger'>[src] blows up in your face.</span>") | ||
|
||
if(M_HULK in M.mutations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a proc for this I'm 99% sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm grepping "hulk" and I can't find anything, only the same "in mutations" check, I don't think there is a proc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be, but that sounds like a job for a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't somebody add something like "is advanced tool user"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could've sworn that was related to hulks in some way, guess not.
Alright then.
I still feel like this should've been tagged with [Balance] and had more discussion. |
It's not too late for that but it is sort of too late for this. Please open an issue and we can discuss it. |
ahhhhh this thing is not a child of /gun/