Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #10874, pneumatic cannon cannot be fired by hulks #12952

Merged
merged 1 commit into from Dec 22, 2016
Merged

Fixes #10874, pneumatic cannon cannot be fired by hulks #12952

merged 1 commit into from Dec 22, 2016

Conversation

ghost
Copy link

@ghost ghost commented Dec 20, 2016

ahhhhh this thing is not a child of /gun/

@Shadowmech88
Copy link
Contributor

This isn't really a bugfix, because there's nothing to suggest that the pneumatic cannon was specifically intended to not be able to be fired by hulks.
It's more of a [Balance] change.

@9600bauds
Copy link
Contributor

9600bauds commented Dec 20, 2016

A good chunk of all the issues in the milestone are [Oversights] like that
https://github.com/d3athrow/vgstation13/milestone/15
Besides, Hulks not being able to use almost any other ranged weapon is a solid reason to me

@9600bauds
Copy link
Contributor

But if you really insist I can do 101

@Shadowmech88
Copy link
Contributor

I was just speaking from a tagging/merging perspective.
Whether it's applied to the count or not doesn't matter because the outcome is already illegitimate.

@9600bauds
Copy link
Contributor

Too late #12954

if ((M_CLUMSY in M.mutations) && prob(50))
to_chat(M, "<span class='danger'>[src] blows up in your face.</span>")

if(M_HULK in M.mutations)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a proc for this I'm 99% sure.

Copy link
Contributor

@9600bauds 9600bauds Dec 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm grepping "hulk" and I can't find anything, only the same "in mutations" check, I don't think there is a proc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be, but that sounds like a job for a separate PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't somebody add something like "is advanced tool user"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

atom_2016-12-20_15-37-53
seems to be just another lame competing version of dexterity_check()?
Which excludes catbeasts, so that's nice

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could've sworn that was related to hulks in some way, guess not.

Alright then.

@Probe1 Probe1 added Bug / Fix This is either a bug or a fix for a bug. Oversight Unintended consequence. and removed Bug / Fix This is either a bug or a fix for a bug. labels Dec 20, 2016
@Probe1 Probe1 merged commit 7d90c7a into vgstation-coders:Bleeding-Edge Dec 22, 2016
@Shadowmech88
Copy link
Contributor

Shadowmech88 commented Dec 22, 2016

I still feel like this should've been tagged with [Balance] and had more discussion.

@Probe1 Probe1 added the Balance Potentially going to upset people as it changes balance of the game. label Dec 22, 2016
@Probe1
Copy link
Member

Probe1 commented Dec 22, 2016

It's not too late for that but it is sort of too late for this. Please open an issue and we can discuss it.

ihadtoregisterforthis pushed a commit to ihadtoregisterforthis/fork4 that referenced this pull request Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Potentially going to upset people as it changes balance of the game. Oversight Unintended consequence.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants