PDA alt-click and ctrl-click swapped #12992
Conversation
|
I added this and I agree. The pen was just the first alt+click thing I tried as an experiment. |
Intigracy
added
the
鉂わ笍 Quality of Life 鉂わ笍
|
Make ctrl+click eject the pen then, otherwise you have two shortcuts for ID ejection you silly |
|
Oh, ctrl-click was the shortcut? never mind |
|
Ehhhh it's still not-ideal, alt+click is the one people will try first and ejecting ID is used more often than ejecting the pen. That was lack of foresight in my part. You could swap around the two shortcuts and it'd be better off after people got used to it again. |
despotate
changed the title
|
lol i didnt merge it dont yell at me |
|
For what purpose? |
|
I originally made the PR without knowing that ctrl-click was the shortcut (which is proof that the defaults aren't very good). Bauds informed me that it is a shortcut but told me to swap them instead. Cue outrage when it's merged. |
|
Ignore the thread shitposting. Though Kuranon makes a valid point below. |
|
You didn't know about a shortcut so it's not good? I'd rather not have to relearn a button and go through the pain of pulling out my pen instead of my ID every time just because someone wasn't aware a shortcut existed |
|
It's more about consistency. Alt-Click is the "primary" shortcut, it should handle the most important verbs. Like your ID. Ctrl-Click is much more rare and should be the "secondary" shortcut for useless shit like pens. |
|
People have gotten used to it now though, it's been at least several months like this. There's no reason to change something just because you personally couldn't remember the correct shortcut. Now many people have to change because you couldn't be arsed to learn. bad form |
|
Consistency and standardization of user interface ought to trample the feeble impulses and muscle memory of the unclean. |
|
Are you going to switch dragging to alt as well? Gotta keep it consistent |
|
I don't see why the need to change this |
|
Fuck, downvotes are at critical mass and I'm out of excuses. Gotta dump the heaviest load - responsibility... .... onto bauds who suggested the change. I closed this PR when I found out about Ctrl-Click, but he convinced me to reopen and commit to swapping them. Aim the pitchforks for him. |
|
Please inform the uneducated masses how to make a revert request on this |
|
Yell at probe until he does it for you I AM the masses, look at my commit history, I've done jack shit |
|
@Probe1 revert this mr probe |
|
It makes sense to me |
|
@DrCelt Why do you care that I care? |
|
It's very simple, alt+click is the most common misc. shortcut. Ctrl+click is mostly for dragging, in fact machinery can't have Ctrl+click misc. shortcuts because it conflicts with dragging. So alt+click is the most commonly used one. Ejecting ID is much more commonly used than eject pen. It makes all the sense in the world for it to work that way and not making it that way to begin with was lack of foresight in my part. I occasionally altclicked by mistake only to get my pen instead of my ID, it made so little sense that not even muscle memory made me get it right. If you've already memorized the old shortcut, you'll be very shortly inconvenienced until you catch on to the new proper one, and everyone else in the future won't be inconvenienced by the previous dumb shortcut. |
|
And no it hasn't been "years" quit overreacting |
|
http://ss13.moe/wiki/index.php/Shortcuts Like I said ctrl+click is for dragging mostly, and dragging has priority over everything else that isn't already inside your inventory. You couldn't ctrl+click a chemmaster to eject the beaker, or ctrl+click a portable pump to eject the tank, because dragging would have to take priority since it's more important. |
|
Well done, you changed a wiki. If only it could be changed back with ease.. |
|
You're not even removing the ctrl+click option so why does it matter which is which? |
|
The wiki link was to show that alt+click is the more diverse one. In fact, PDAs are the only thing that even use ctrl+click for anything besides dragging, it seems. |
|
Holy FUCK |
|
I merge like 30 PRs yesterday and I don't hear a word about. PJB merges one and there's a riot. I know which track the train is on.
|
|
The game works fine without the change though, it's just enforcing shit on players to fufill your own autistic desires of keeping the code consistent. Funny isn't it that when it's posted to the thread there's an outrage, as if the actual playerbase doesn't want this and the only people that support it are coders that infrequently play the game anyway. I'm certain if the playerbase knew about this PR before it was merged the thumbs down would greatly outweigh thumbs up. It's a pointless change that annoys players and doesn't improve the game in any way, why keep something like that? |
Have you ever coded before? Consistency isn't something you do just as an "autistic desire". There are plenty of changes that are necessarily painful in the short term that lead to greater gains in the long run. |
|
How would this improve the GAME that hundreds of people play. I understand it makes the code prettier and more standardized, but how does this change improve the game that the code affects? The game in my opinion should come before the consistency of the code. |
|
I hope you all realize you guys are wrong. Objectively. Deal with it. |
Actually that sounds to me more like it's the thread overreacting, if the playerbase didn't want it so bad they would have complained as soon as they saw the changelog |
|
Nobody ever said anything about consistency of the CODE. In fact this makes no difference to the CODE. It's about making the existing shortcuts more intuitive. |
|
What greater gain in the future will this give?
This is exactly what I did |
|
Good thing I merged this before these shitters got wind of it jesus, then I might've actually not merged it because of how controversial this change apparently is. But anybody against this because change is bad is objectively wrong so deal with it. |
|
I'm pretty sure you've all spent more energy complaining about this than it would take to get used to it |
|
Make a revert PR and stop spending your time arguing in this merged issue which isn't going to get it reverted. You don't even have to code it you just press the revert button. |
|
yeah fuck this I'm supposed to be looking up antag datums, this is Parkinson's Law of Triviality at its finest. |
|
Decisions are hard to make and consume willpower. Even something as small as having to decide whether to use ctrl-click or alt-click for your widget results in an opportunity cost of improving that widget further. Standardizing to alt-click ends that debate and lets us work on future features with one less thing nagging at the back of our heads. |
|
using ctrl is much easier, so in my opinion all the most used options should be used with ctrl+click instead of alt+click: PDA ejecting IDs, setting suit sensor, etc. |
|
Issue is ctrl conflicts with pulling. |
|
I'm 90% sure neither PDA shortcut works if you aren't holding it |
|
Or I mean |
* Changes alt-click behaviour of PDA from removing pen to removing ID * altclick ctrlclick swap
Far more people will be convenienced by this change than inconvenienced.
馃啈