Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peacekeeper borgs. #13814

Merged
merged 2 commits into from Feb 5, 2017
Merged

Peacekeeper borgs. #13814

merged 2 commits into from Feb 5, 2017

Conversation

PJB3005
Copy link
Contributor

@PJB3005 PJB3005 commented Feb 4, 2017

http://ss13.pomf.se/index.php/poll/27
#7944

馃啈

  • tweak: Security borgs have been renamed to Peacekeeper borgs, and the sprite colour scheme is changed to baby blue.

@PJB3005 PJB3005 added the Balance Potentially going to upset people as it changes balance of the game. label Feb 4, 2017
@PJB3005
Copy link
Contributor Author

PJB3005 commented Feb 4, 2017

I need the Kodiak sprite to be converted, @Dizor could you help out here? If not I'll do it myself but I'll probably butcher it.

@Shaska-
Copy link
Contributor

Shaska- commented Feb 4, 2017

Please tell me this isn't the baby-blue borgs.
I'm fine with the rename though.

@PJB3005
Copy link
Contributor Author

PJB3005 commented Feb 4, 2017

It is.

@PJB3005
Copy link
Contributor Author

PJB3005 commented Feb 4, 2017

N o p e.

@PJB3005
Copy link
Contributor Author

PJB3005 commented Feb 4, 2017

Not up for debate, the chicken spoke.

@Allspice
Copy link
Contributor

Allspice commented Feb 4, 2017

Who said what where

Oh hm, two gitthing links deep. With how garish that shade of blue is, I wonder if the initial vote even indicated to players how wonky it is.

@Ephx1
Copy link

Ephx1 commented Feb 4, 2017

OH MY GOD IT'S HAPPENING AGAIN!
Though, don't we already have the big red text that tells secborgs to fuck off with acting like sec if it doesn't fit their laws?
I can't really tell if that has worked because I personally haven't directly interacted with a secborg in a very long time.

@RemieRichards
Copy link

you should port the real peacekeepers :^)

@Aurantiaco
Copy link
Contributor

BWEEP BWEEP

HUMAN HARM

BWEEP BWEEP

@SkowronX
Copy link
Contributor

SkowronX commented Feb 4, 2017

wee woo wee woo

@Probe1
Copy link
Member

Probe1 commented Feb 4, 2017

oh boy here we go

@PJB3005
Copy link
Contributor Author

PJB3005 commented Feb 4, 2017

I had to reread that comment 3 times before I understood it.

@Shadowmech88
Copy link
Contributor

That server poll is nearly two years old.
It's highly likely that our playerbase has changed since then.
At the very least, I think a new poll is necessary.

@SageOfLight
Copy link
Contributor

SageOfLight commented Feb 4, 2017

Just remember to update red/blue knight 2.0 to being "Sleek" like all the other Sleek borgs. :^)

I had Duny originally help me apply those since I didn't understand github worth shit.

@DoctorMonkey
Copy link

Got excited when I saw this because i thought it was /tg/s hugborgs

@Blithering
Copy link
Contributor

I prefer the spicy flavour borgs to the cool mint. Hugborgs as a new option would be nice though.

@PJB3005
Copy link
Contributor Author

PJB3005 commented Feb 4, 2017

Ready for merge.

@Arthurdentist
Copy link
Contributor

Give every assistant a roundstart potent ham instead

@gbasood
Copy link
Contributor

gbasood commented Feb 5, 2017

add a changelog and it's good to go

@PJB3005
Copy link
Contributor Author

PJB3005 commented Feb 5, 2017

Done.

@gbasood gbasood merged commit 19aaa18 into vgstation-coders:Bleeding-Edge Feb 5, 2017
@Shadowmech88
Copy link
Contributor

Why did this get merged based on the outcome of a poll that's two years out of date?

@PJB3005
Copy link
Contributor Author

PJB3005 commented Feb 5, 2017

Better late than never?

@PJB3005 PJB3005 deleted the BABYBLUE branch February 5, 2017 01:15
@Anglosphere
Copy link
Contributor

A vote is a vote is a vote. Just because a vote was made two years ago, doesn't mean its any less valid today. Presidential Votes in most countries remain valid for 4+ years after the vote. We can pick borg changes, based on two year old plebiscites as well.

@Intigracy
Copy link
Contributor

Because Pomf wanted it too when it was brought up before, it just didn't get done.

@Shadowmech88
Copy link
Contributor

But the playerbase has almost certainly changed. A significant portion of the players who voted on the original poll likely aren't even here anymore, and we certainly have a large volume of players who arrived since then that may have a different opinion.

There should have been another poll to measure what people want now, we shouldn't make changes based on what people did want years in the past.

@Intigracy
Copy link
Contributor

Jul 02 06:50:04 <D3athrow>  http://ss13.pomf.se/index.php/poll/27
Jul 02 06:50:09 <D3athrow>  get to it Intigracy
Jul 02 06:50:35 <Intigracy> So just rename the module?

Jul 02 06:57:48 <D3athrow>  Intigracy rename and make the secborg baby blue
Jul 02 06:57:55 <Intigracy> cool

From the oldest PR on the subject
#5223

@Shadowmech88
Copy link
Contributor

That chatlog implies that he told you to make it as a result of the poll's outcome, given that he linked it first.

@Allspice
Copy link
Contributor

Allspice commented Feb 5, 2017

Did the god damn poll even link to the PR with the sprites?

@Shadowmech88
Copy link
Contributor

It did not.

@Ephx1
Copy link

Ephx1 commented Feb 5, 2017

I suggest Hot Pink

@gbasood
Copy link
Contributor

gbasood commented Feb 5, 2017

we'll do a new poll in a day or two

@mrpain666
Copy link

Baybies lol fucking knew it. What did you expect with the tyrant Mr. Pain at the helm? May as well remove stuns now lol

Yep. And remove guns and weapons from the game. Wouldnt want anyone's feelings getting hurt.

@9600bauds
Copy link
Contributor

馃帀馃帀馃帀馃憦馃憦馃敟馃馃敟馃憦馃憦馃帀馃帀馃帀

@TheFriggenSawbones
Copy link
Contributor

100% tested

@Probe1
Copy link
Member

Probe1 commented Feb 5, 2017

why did it break something?

@TheFriggenSawbones
Copy link
Contributor

#13833

@ihadtoregisterforthis
Copy link
Contributor

wut-faces

@NigglyWiggly
Copy link
Contributor

Servbots made grey

I am going to fucking hurt you.

@Probe1
Copy link
Member

Probe1 commented Feb 11, 2017

We really need to revert the color aspect it looks much worse. And it just makes everyone dislike the name change.

@Intigracy
Copy link
Contributor

I'll make it suck less this week.

@IratePirate
Copy link
Contributor

Why would you do this?

ihadtoregisterforthis pushed a commit to ihadtoregisterforthis/fork4 that referenced this pull request Jul 3, 2017
* Peacekeeper borgs.

* Fixes the kodiak. Thanks Dizor!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Potentially going to upset people as it changes balance of the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet