reverts Kolith's shotgun rework

[SonixApache]

for @yclatious / @aratherangryduck because he's too much of a lazy shitbag to do it himself and instead asks me to do it

Personally I think the rework is a mixed bag; I like some of the features, but I feel it's made shotguns even more tedious to use. I wouldn't mind the rework if we had CM's ammo pooling feature.

Tested.

[aratherangryduck]

Alright, lemme put my thoughts in a more clear manner then so this isn't brushed off as just a greytider who doesn't like change or something like that.

As a player, I know ss13 isn't perfect by any manner of the imagination. I know the UI is clunky and puts off people, I know it doesn't have the best looks, the best optimization or, hell, the best anything, but for me that doesn't mean we have to make it even worse.

Shotguns, when they were one handed, worked well. Im not going to say they were perfect, or that they were or should be considered, at that time, to be at the best place they could ever be, but they worked, for better or worse, it acted like a shotgun, felt decent enough to use, was not imbalanced in its usage and felt right. You could use it with a shield in hand or any other thing and it was adaptable, if you get my meaning. It didn't constrict you with fiddly controls, fucking with inhands, changing hands, making you macro buttons to get over it being made, for a lack of a better description, needlessly complex in usage when previously they were much more comfortable to use, it just felt simple and right. Load the shells in, pump it with activate hand, shoot shit, activate hand, repeat till empty and until you get your results.

I dislike ranting overtly or talking about game design in ss13 because inevitably you get to the point where you are either spouting shit, hit the bullseye or make some sense but word it badly, so Im going to cut it as short as I can. The sprites look bad, it made it unwieldy instead of intuitive and practical and it was aparently based on shotguns being good or something. If we are going to go the colonial marines way, which I sincerely hope we don't, I want to see it be done much beter than this, because I simply cannot stand it and I doubt many others liked how it was implemented.

Also, sorry for being a ass sonix. You a good dude for doing this.

[Intigracy]

Hell the part with having to wield it to fire is fine.

Everything else was just stupid.

[Allspice]

You'd still have two behaviors to one button, which seems sketchy to me.

[Aurx]

The fundamental issue is that shotguns should be usable without having to ask how the fuck they work.
Intuitive behavior is king, and the rework was not intuitive.

[SonixApache]

maybe i should keep the thing where clowns 'break' the gun in

[Exxion]

I was pretty neutral on the rework
Then I actually had to experience it

[kol1th]

I like the "Revert everything instead of figure out how to make it work better" episode. It's my favorite re-run.

[Intigracy]

I gave a way to make it work better.

Just because you don't like the feedback doesn't mean it's not there.

[kol1th]

I don't remember you saying anything on how to make it function better, just code review.

[Exxion]

Honestly, the only really bad part is unwielding the gun
Having to switch hands to do so is... rather unwieldy (pun legitimately not intended)

[kol1th]

I'm not sure of a way around that. It would work for say, ion rifles, but eh.

[Intigracy]

"Hell the part with having to wield it to fire is fine.

Everything else was just stupid."

I'm not sure of how to make unwielding it less unwieldy, except maybe making it an alt click shortcut.

[Exxion]

I don't know if Alt+click would really be much better

Something that WOULD be much better would be the ability to unwield and put away in one click, rather than having to unwield first
Not really sure why that's not already how it works

[Blithering]

I'd say realism can be dialled back for gameplay's sake. Holding a gun in one hand isn't realistic but with the interface we have it's what works best.

[SonixApache]

Dropping the gun while it's wielded to unwield it might be a good idea.

[kol1th]

Not quite sure if there's a way to override dropping like that, but there might be. I'll look and ask around.

But let's just revert it first. Thanks @yclatious !

[Shadowmech88]

@Kolith
It could be accomplished by overriding dropped(), having it check if it's wielded and, if so, putting it back into the mob's hand.

[kol1th]

I'll try and work something up either later this evening or tomorrow, not feeling it much right now. Chances are this will get merged before then, though. The way Probe's been talking towards me in the coder discord lead me to believe he wants this OUT.

[SonixApache]

@kol1th you can stop with the passive aggressive shit, y'know.
We all make mistakes in our PRs sometimes.
Some shit gets reverted because it annoys everyone even if it's positive in some ways.

[Exxion]

Calm down it already got reverted

[Probe1]

Expressing yourself is the key to self realization.