Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-layer piping #4953

Conversation

ComicIronic
Copy link
Contributor

Pipes and pipe items now have a pipe_layer var which controls which layer they're on.
Current pipes now only connect to other pipes on the same layer as them, and it is possible to stack multiple pipes on a tile.
The layer of a pipe item can be changed by using a pipe planner, aligning with a built pipe using the RPD or a pipe item, or setting the alignment on the pipe dispenser.
Added the isConnectable() proc for OOP way of checking if two pipes can do the do.
Added the layer manifold - this pipe has 5 connectors on one side, and one on the other. It acts as a layer converter.
Pipes change their pixel_x and pixel_y according to their pipe layer.

This gives such wonderful setups as:

The Twister

Yeah, no

The Heavy Lifter

Its still a bottleneck

The "Really, dude?"

Volume and style

The Octopus

Dont count the legs

@IratePirate
Copy link
Contributor

Absolutely glorious. We can finally stop pipes being forced under walls.

@FudgePucker
Copy link
Contributor

Oh boy. The fun you can have with these.
Time to use these as a mommi to make atmos into autistic unpainted spaghetti.

@FudgePucker
Copy link
Contributor

Oh man after looking at the twister I think this is FUCKING FANTASTIC. You can still make out complex designs.
You can also have fun antag gimmicks with it.

one of these valves will put air into this depressursing room, the others will fill it with plasma, good luck.

@PJB3005
Copy link
Contributor

PJB3005 commented Jun 13, 2015

👍 DUDE THIS IS FUCKING AMAZING

@FudgePucker
Copy link
Contributor

Now all we need are vigesimal devices for twenty pipes.
Maybe a new atmos based engine to replace the broken rust engine.

@SkowronX
Copy link
Contributor

It begins. Now we see what bugs need ti hunted down.

@Exxion
Copy link
Member

Exxion commented Jun 13, 2015

Holy shit I was thinking about exactly this a few weeks ago except my idea for how to select the layer was vastly worse
👍✖️💯⬆️⬆️💯

Is there a way to connect two pipes on different layers other than with the manifold? I think I had a reason for wanting this ability, but I don't remember what it was.

@ComicIronic
Copy link
Contributor Author

Is there a way to connect two pipes on different layers other than with the manifold?

No.
I was originally working on something like that, but I decided it was redundant thanks to the manifold anyways.

@BestName
Copy link
Contributor

So how does this affect vent crawling?
How do you choose which pipe to enter?

@d3athrow
Copy link
Collaborator

This disturbs me

@FudgePucker
Copy link
Contributor

What? You don't like autistic spaghetti?
This will make optimizing atmos so much easier.

@ChangelingRain
Copy link

This is such an atrocity, I love it.

@ComicIronic
Copy link
Contributor Author

ventcrawling

I knew I'd forgotten something.
I'll push a fix for that and meters in a bit.

@ghost
Copy link

ghost commented Jun 13, 2015

Beautiful.

@FudgePucker
Copy link
Contributor

I can't wait to make pipe mazes for the other mommis to solve

@SangriaMonkey
Copy link

Can you stick h/e pipes in those?

@FudgePucker
Copy link
Contributor

That might be too op.
You could put 5 h/e pipes in the same place

@SangriaMonkey
Copy link

But that'd be sweet.
Or five lines of manifolds with thermal plates. Seven kelvin or bust.

@ghost
Copy link

ghost commented Jun 13, 2015

So wait, how do you choose a pipe's layer when wrenching it down ?

Also, I'll likely attempt the general re-piping once this is released, given that I already re-piped the entire map back when half of the map's piping when under walls

@SangriaMonkey
Copy link

I wouldn't redo the whole station. Having to alt click constantly to see/repair disposal pipes would be such a fucking pain.

@FudgePucker
Copy link
Contributor

I don't think that having unary devices was going to be allowed.
20 vents, scrubbers, injectors, and thermal plates.
Although the thought does get me ROCK HARD

@VelardAmakar
Copy link
Contributor

Holy fucking shit.

@ComicIronic
Copy link
Contributor Author

So wait, how do you choose a pipe's layer when wrenching it down ?

The pipe dispenser machine dispenses pipes at a set layer.
The RPD can dispense pipes at the same layer as a pipe that it is used on.
You can use a pipe on a pipe planner to align in to the desired layer.
You can use a pipe on an existing pipe to align it to that pipe's layer.

@Exxion
Copy link
Member

Exxion commented Jun 13, 2015

The overlap issue with the far left/top pipe layer and the manifold irks me

@Exxion
Copy link
Member

Exxion commented Jun 13, 2015

And bottom/far right on the other end

Where the fuck is the edit comment button on mobile?
inb4 >Using mobile

@FudgePucker
Copy link
Contributor

Then my twenty injectors and scrubbers will drive you up the wall

@ComicIronic
Copy link
Contributor Author

Alright, meters and ventcrawling are now up-to-date as well.

@FudgePucker
Copy link
Contributor

Noice

@ComicIronic ComicIronic added the System Modifies an underlying system within the game, may not affect players in any way. label Jun 14, 2015
@demonfiren
Copy link

I can atmos so hard to this.

@ComicIronic
Copy link
Contributor Author

What do you mean?

@ririchiyo
Copy link
Contributor

Forgive the terrible webm I threw together in seconds: https://λ.pw/y7x

@Exxion
Copy link
Member

Exxion commented Jun 15, 2015

I hope so because that was horrifying
I especially hope so because if it doesn't, it would presumably allow for 15 HE pipes on the same tile

@FudgePucker
Copy link
Contributor

I want to be able to make octopuses and other pipe designs everywhere on the station as a MoMMI :3
Merge when?

@d3athrow
Copy link
Collaborator

THIS IS 100% DISGUSTING DO PEOPLE REALLY WANT THIS MERGED?

@Probe1
Copy link
Member

Probe1 commented Jun 20, 2015

Eh. I'd love to have multiple pipes per tile. We come up with some creative, and pitiful, designs to get around it.

I'm not in love with the sprites but I have wanted bays multiple pipes per tile for a long time. I'll take what I can get.

@PJB3005
Copy link
Contributor

PJB3005 commented Jun 20, 2015

@d3athrow, is that even a question? MERGE NOW!

@FudgePucker
Copy link
Contributor

@d3athrow
YOU CAN HAVE TWENTY THERMAL PLATES ON THE SAME TILE
TWENTY
TWWWWWEEEEEEEEEEENNNNNNNNNNNTTTTTTTTTTYYYYYYYYYYYYYYYYYYYYYYYYY
JUST LOOK AT THAT HEAVY LIFTER IMAGE, FUCKIN LOOK AT THAT SHIT, OH GOD I AM SO HARD RIGHT NOW HRRRRRRRRRRRNNNNNNNNGGGGGGGGGGGGGG.

Merge when?

@PJB3005
Copy link
Contributor

PJB3005 commented Jun 20, 2015

If you're limiting stacking 4 devices to a tile, atleast make some devices such as vents capable of connecting with multiple channels of pipes

@ComicIronic
Copy link
Contributor Author

make some devices such as vents capable of connecting with multiple channels of pipes

I don't understand this.
If you mean being able to change the layer of vents, you can do that.
If you mean being able to connect a vent to more than one layer, use a manifold dummy.

@PJB3005
Copy link
Contributor

PJB3005 commented Jun 20, 2015

Well, nevermind that actually, I was dumb.

@FudgePucker
Copy link
Contributor

@clusterfack
Deep down inside your heart, there is some part of you screaming out, 'YES, YES, TWENTY INJECTORS/SCRUBBERS/THERMAL PLATES ON THE SAME SPOT. BALANCE CAN GO FUCK ITSELF.'

@FudgePucker
Copy link
Contributor

@clusterfack
Ah didn't think of it that way.

@FudgePucker
Copy link
Contributor

#5163
I came up with an idea that would use this.

@Kurfursten
Copy link
Collaborator

When?

@ComicIronic
Copy link
Contributor Author

Don't open Pandora's box unless you can handle what's inside.

@PJB3005
Copy link
Contributor

PJB3005 commented Jul 23, 2015

inb4 I will need to maintain this.

comic pls

@SkowronX
Copy link
Contributor

W H E N

H

E

N

Pipes and pipe items now have a pipe_layer var which controls which layer they're on.
Current pipes now only connect to other pipes on the same layer as them, and it is possible to stack multiple pipes on a tile.
The layer of a pipe item can be changed by using a pipe planner, aligning with a built pipe using the RPD or a pipe item, or setting the alignment on the pipe dispenser.
Added the isConnectable() proc for OOP way of checking if two pipes can do the do.
Added the layer manifold - this pipe has 5 connectors on one side, and one on the other. It acts as a layer converter.
Pipes change their pixel_x and pixel_y according to their pipe layer.
…by layer and change layer in layer manifolds, made ventcrawling use forceMove, changelog.
@ririchiyo ririchiyo added the Conflicts Conflicts with something. label Aug 4, 2015
//writepanic("[__FILE__].[__LINE__] (no type)([usr ? usr.ckey : ""]) \\/proc/Ceiling() called tick#: [world.time]")
. = -round(-x / y) * y
/proc/Ceiling(x)
return -round(-x)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply comical

@N3X15 N3X15 closed this Sep 17, 2015
@Probe1
Copy link
Member

Probe1 commented Sep 18, 2015

comics da best

@PJB3005
Copy link
Contributor

PJB3005 commented Sep 19, 2015

@Aranclanos oi nerd we merged this on GitLab, come at us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Conflicts Conflicts with something. System Modifies an underlying system within the game, may not affect players in any way.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet