Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sankey Chart is hard coded to use TWh as a unit in tool tops #10

Closed
JohnOmernik opened this issue Dec 21, 2022 · 2 comments
Closed

Sankey Chart is hard coded to use TWh as a unit in tool tops #10

JohnOmernik opened this issue Dec 21, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@JohnOmernik
Copy link

Probably from this line:

d3blocks/d3blocks/sankey/d3js/sankey.html.j2

Line 64 in 53169b5

format: (value) => `${value.toFixed(1)} TWh`,

Having a variable for units (or None) would be preferred.
@erdogant erdogant added the enhancement New feature or request label Jan 8, 2023
@erdogant
Copy link
Collaborator

I removed the string TWh. The update will be visible in release v1.2.8.

@erdogant
Copy link
Collaborator

erdogant commented Feb 9, 2023 •
edited

Fix is available in latest version.
pip install -U d3blocks

@erdogant erdogant closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JohnOmernik @erdogant