Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon dependency tool #35

Closed
4 of 5 tasks
Daandelange opened this issue Sep 21, 2020 · 8 comments
Closed
4 of 5 tasks

Addon dependency tool #35

Daandelange opened this issue Sep 21, 2020 · 8 comments
Labels
enhancement New feature or request feedback-needed

Comments

@Daandelange
Copy link
Collaborator

Daandelange commented Sep 21, 2020

#34 integrates a beta version for a dependency checker.
Only tested on osx 10.12 so far. Feedback is appreciated.

I'd like to extend it at least with the following functionality.

  • Test multi-platform
  • Parse addon dependencies (parsing addons/ofxXyzAddon/addons.make)
  • Add option to install (clone)
  • Add option to update repos and their submodules (clone)
  • Add option to sync addons.txt with addons.make for easier dependency maintenance.

What about creating a Mosaic/utilities/addonTool/check_addons.sh folder to host this script ?
I could also create a new repo for it (useful for other OF projects) and make it a Mosaic submodule.

Any other ideas ?

@Daandelange Daandelange added enhancement New feature or request feedback-needed labels Sep 21, 2020
@d3cod3
Copy link
Owner

d3cod3 commented Sep 21, 2020

Yes, i was checking the script yesterday, works on linux ( ubuntu/debian, will test on others ) perfectly!

I like the submodule approach, i'm going to add a specific folder for scripts ( Mosaic/scripts/ ) then we can store there all scripts utils as submodules ( this one as others in the future )

With the addons.txt ( maybe could be better to use addonsDependencies.txt ? ) syncing, it is an universal tool for every OF application, i think it's a great contribution!

I'll wait for your repo with this addonTool ( suggestion names: ofxAddonChecker, ofxAddonTool, ofxAddonManager ) and when is ready i'll add the folder and the submodule inside.

@Daandelange
Copy link
Collaborator Author

Ok, the initial repo is setup here.
https://github.com/Daandelange/ofxAddonTool
(Lots of changes under the hood, but features are not yet extended.)
It should run out of the box; do you want to install the submodule ? (otherwise I can make a PR)

@d3cod3
Copy link
Owner

d3cod3 commented Sep 29, 2020

Already added as submodule!
Tested and running fine, just one small issue, in the readme in Installation:

you have brew install figment

but it must be brew install figlet

figment is throwing an error: No formulae found in taps

@d3cod3
Copy link
Owner

d3cod3 commented Oct 6, 2020

Just tested on MSYS2 ( windows ), it works but do not visualize right

Sin título

Probably because it needs figlet or toilet, but pacman -Syu figlet toilet doesn't find the packages.

@Daandelange
Copy link
Collaborator Author

Daandelange commented Oct 6, 2020

Thanks for testing !

No, figlet or toilet are 100% optional, weirdly an error is displayed, but the fallback works. (Project: Mosaic instead of ASCII banner Mosaic, nothing more).
On Unix systems, I redirect the output of the commands to /dev/null to hide errors, I think this doesn't work on M$ systems...

Regarding the broken table columns, it looks like the latest changes that adapt the column width to the terminal width broke it, needing the bc command to floor float calculations. From what I understand, bc is part of GNU, not bash, and there are different bash environments on Windows, GitBash being very minimal (are you using this?). bc could be installed, but awk which seems more universal, could you try this ? Daandelange/ofxAddonTool@5286e9b
Edit: Newer commits available, everything in your screenshot should be fixed now.

@d3cod3
Copy link
Owner

d3cod3 commented Oct 6, 2020

Yes, your commit fixed the issue on MSYS2, great!

Before trying it, i've installed bc:

pacman -Syu bc

and it solved the issue

Sin título

But it's probably better to use awk, less instructions for the users

@Daandelange
Copy link
Collaborator Author

Ok, great. Did the "figlet/toilet command not found" messages go away too ?
There also seems to be a bug when addons are on a detached head.... there's a possible fix in new commit.

@Daandelange
Copy link
Collaborator Author

Closing this, as it seems to be working. For further issues we can always open issues in the submodule repo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feedback-needed
Projects
None yet
Development

No branches or pull requests

2 participants