-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib): add input to control starting drag select over items #117
Conversation
Hey @clarencecastillo 馃憢 Thanks a lot for this PR, I really appreciate your contribution and this is indeed a great feature. I looked at your PR and the only thing I would change is the default to |
src/app/app.component.ts
Outdated
@@ -19,6 +19,7 @@ export class AppComponent implements OnInit { | |||
disableRangeSelection = false; | |||
isDesktop = false; | |||
selectWithShortcut = false; | |||
dragOverItems = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default should be true
, otherwise this is a breaking change and requires a new major release, while true
allows us to publish a new minor version.
4074d73
to
1ac0ee8
Compare
Cool, I've changed the default to |
Thanks for this PR. I have just merged it. |
Thanks for the great work! I was wondering, why is this pr not available? I tried to use the input but it doesn't seem to work for me: |
Hey @sam-eah! I just checked the live demo, and it seems to still work fine over there. Also, I don't see any other changes to the project since this was merged. Can you maybe create a separate issue with some snippets? This is a common error and it's usually due to typos or wrong module imports. |
Hi, sorry to reopen this, but I have created an issue, did you see it? Hope I'm not bothering you, thanks again |
Thank you so much for this awesome lib! This small PR adds a new input
dragOverItems
todts-select-container
which controls whether drag selection should be allowed to start when the click started from inside an item, and not the container itself.I've set the default behavior to
false
though it deviates from the lib's current state. Please let me know if it needs more work 馃檹Closes #76