Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): add input to control starting drag select over items #117

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

clarencecastillo
Copy link
Contributor

Thank you so much for this awesome lib! This small PR adds a new input dragOverItems to dts-select-container which controls whether drag selection should be allowed to start when the click started from inside an item, and not the container itself.

I've set the default behavior to false though it deviates from the lib's current state. Please let me know if it needs more work 馃檹

Closes #76

@d3lm
Copy link
Owner

d3lm commented Feb 3, 2021

Hey @clarencecastillo 馃憢 Thanks a lot for this PR, I really appreciate your contribution and this is indeed a great feature.

I looked at your PR and the only thing I would change is the default to true.

@@ -19,6 +19,7 @@ export class AppComponent implements OnInit {
disableRangeSelection = false;
isDesktop = false;
selectWithShortcut = false;
dragOverItems = false;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default should be true, otherwise this is a breaking change and requires a new major release, while true allows us to publish a new minor version.

@clarencecastillo
Copy link
Contributor Author

Cool, I've changed the default to true so now behavior should be the same with current version's state.

@d3lm d3lm merged commit 868a117 into d3lm:master Feb 8, 2021
@d3lm
Copy link
Owner

d3lm commented Feb 8, 2021

Thanks for this PR. I have just merged it.

@sam-eah
Copy link
Contributor

sam-eah commented May 6, 2021

Thanks for the great work! I was wondering, why is this pr not available? I tried to use the input but it doesn't seem to work for me: can't bind to 'dragOverItems since it isn't a known property of 'dts-select-container'

@clarencecastillo
Copy link
Contributor Author

Hey @sam-eah! I just checked the live demo, and it seems to still work fine over there. Also, I don't see any other changes to the project since this was merged.

Can you maybe create a separate issue with some snippets? This is a common error and it's usually due to typos or wrong module imports.

@sam-eah
Copy link
Contributor

sam-eah commented May 31, 2021

Hi, sorry to reopen this, but I have created an issue, did you see it? Hope I'm not bothering you, thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Do not allow selecting items dragging over items
3 participants