fix(lib): keep selection when selectableItems change (#139) #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3lm
reviewed
Sep 22, 2021
|
Nice! Thanks for this PR 🙏 Really appreciate it 💯 |
d3lm
requested changes
Sep 22, 2021
|
Happy to contribute :) |
|
Hi @d3lm, any idea when you'll be able to take a look at this, and hopefully accept the pull request? |
|
Oh sorry, totally forgot about this. I ll have a look over the weekend so we can get this in. Thanks for reminding me 🙏 |
|
Two weekends later... 😉 |
|
Looks like a fix I could use as well. can't work out why the pull request isn't merged though? |
|
Would be awesome if we could get this merged @d3lm! ⭐ |
|
Ok, I have done some general maintenance over the weekend and finally merged this PR. Thanks for collaborating! |
d3lm
pushed a commit
that referenced
this pull request
Dec 5, 2021
|
For your information, this is available in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request which fixes #139