Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES5 compatibility in latest version #101

Closed
cheryllaird opened this issue Jul 31, 2019 · 4 comments
Closed

ES5 compatibility in latest version #101

cheryllaird opened this issue Jul 31, 2019 · 4 comments
Assignees
@davelandry
Labels
bug chore
Projects
1.0 d3plus

Comments

@cheryllaird
Copy link

We updated to version 0.6.53 and noticed that the new dependency of locale-codes is ES6.
This is causing problems similar to #100 with ES5 compatibility.

Not a problem as we have pinned to an older version but wanted to make you aware.

Many thanks :)
@davelandry
Copy link
Member

Ahhh yikes, good catch. We're only using a very small part of that library, so it should be easy for us to fix this.

@davelandry davelandry self-assigned this Jul 31, 2019
@davelandry davelandry added this to To do in 1.0 via automation Jul 31, 2019
@davelandry davelandry added this to To do in d3plus via automation Jul 31, 2019
@cheryllaird
Copy link
Author

Oh that is great news, I will look out for the update. Thank you for your work on this.

@davelandry davelandry moved this from To do to In progress in d3plus Aug 5, 2019
1.0 automation moved this from To do to Done Aug 7, 2019
d3plus automation moved this from In progress to Done Aug 7, 2019
@davelandry
Copy link
Member

@cheryllaird I just released v0.6.54 with a fix, let me know if that doesn't work for you!

@cheryllaird
Copy link
Author

Great, we are now on the latest version and all looks good. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davelandry davelandry

Labels
bug chore
Projects
d3plus
  
Done
1.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davelandry @cheryllaird