Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected Legend Behavior in Treemap #103

Closed
tgrehn opened this issue Dec 20, 2018 · 3 comments
Closed

Unexpected Legend Behavior in Treemap #103

tgrehn opened this issue Dec 20, 2018 · 3 comments
Assignees
Labels

Comments

@tgrehn
Copy link

tgrehn commented Dec 20, 2018

I have a dataset of companies and their products. I created a Treemap and grouped the dataset by company and products.

If a company has only one product in the dataset, the Legend does not display the company's name but the product's.

I would expect the Legend to show the first level's identifier (here: company name) and not the second level's identifier.

Example: http://jsfiddle.net/g149pjqo/3/

@davelandry davelandry transferred this issue from d3plus/d3plus-hierarchy Dec 20, 2018
@davelandry davelandry added the bug label Dec 20, 2018
@davelandry
Copy link
Member

Good catch @tgrehn, thanks for reporting.

@cnavarreteliz can you look into this? Could be related to this:

https://github.com/d3plus/d3plus-viz/blob/master/src/_drawLegend.js#L9-L12

Or this:

https://github.com/d3plus/d3plus-viz/blob/master/src/Viz.js#L278-L287

@tgrehn
Copy link
Author

tgrehn commented Dec 20, 2018

Wow, stunned by your quick replies and fixes! Thank you very much!

I patched my local files and it works as expected now!

@tgrehn
Copy link
Author

tgrehn commented Jun 13, 2019

Could you tell me when the fix will be available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants