Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https-proxy-agent update requires manual review #678

Closed
pachadotdev opened this issue Feb 12, 2019 · 1 comment
Closed

https-proxy-agent update requires manual review #678

pachadotdev opened this issue Feb 12, 2019 · 1 comment

Comments

@pachadotdev
Copy link

HI @davelandry

I cloned branch 2.0 again and as in it works out of the box.

The only detail is that npmreturn a several warning and npm audit fix gives a message that one vulnerability needs manual review:

┌──────────────────────────────────────────────────────────────────────────────┐
│                                Manual Review                                 │
│            Some vulnerabilities require your attention to resolve            │
│                                                                              │
│         Visit https://go.npm.me/audit-guide for additional guidance          │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High          │ Denial of Service                                            │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ https-proxy-agent                                            │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=2.2.0                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ d3plus-dev [dev]                                             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ d3plus-dev > github-issues-label-sync > github >             │
│               │ https-proxy-agent                                            │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/593                       │
└───────────────┴──────────────────────────────────────────────────────────────┘
found 1 high severity vulnerability in 11635 scanned packages
  1 vulnerability requires manual review. See the full report for details.
@davelandry
Copy link
Member

Thanks @pachamaltese, I've moved this do d3plus-dev: d3plus/d3plus-dev#104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants