Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Sign in with LinkedIn and introducing OpenID #91

Closed
dzab5 opened this issue Nov 14, 2023 · 9 comments
Closed

Removing Sign in with LinkedIn and introducing OpenID #91

dzab5 opened this issue Nov 14, 2023 · 9 comments
Assignees
Labels
FAQ List of questions that can be candidates for documentation post feature request !!!IMPORTANT!!! resolved

Comments

@dzab5
Copy link

dzab5 commented Nov 14, 2023

Given as linkedin recently deprecated the apis this package uses (https://learn.microsoft.com/en-us/linkedin/consumer/integrations/self-serve/sign-in-with-linkedin).

Is there any plan to adjust this package to use Open Id connect? (https://learn.microsoft.com/en-us/linkedin/consumer/integrations/self-serve/sign-in-with-linkedin-v2).

I am asking because the scopes used by this package of r_profile_lite and r_emailaddress are no longer used, which i believe renders this package obsolete at the moment?

@dzab5 dzab5 added bug Something isn't working FAQ List of questions that can be candidates for documentation post labels Nov 14, 2023
@d3xt3r2909 d3xt3r2909 added feature request and removed bug Something isn't working labels Nov 14, 2023
@d3xt3r2909
Copy link
Owner

Hey, thanks for raising this issue. Tbh I don't have time lately to check the impact on it, but since Microsoft is being Microsoft the impact is huge.

Anyhow will do spike these days on workload and give ETA on upgrade..

@d3xt3r2909
Copy link
Owner

d3xt3r2909 commented Nov 14, 2023

Ok just a small update, I made POC and seems like its working.

There will be some breaking changes of course for this so cannot just simply patch it, need a bit of testing and then will merge it to technical preview. This will take some days.

Documentation for migration of this is really really poor. But in theory from now on when we are creating new app inside linkedin console instead of choosing product sign in, we must include OICD

image

Also instead of previously called permissions as you said r_profile_lite and r_emailaddress there are new once: openid, email, profile.

This means that API that was before used to get user information will be deprecated too (even they didn't wrote this anywhere; but you cannot use it without r_profile_lite and r_emailaddress) so instead of this profile this library will start using https://api.linkedin.com/v2/userinfo (doc) which means that instead of previously complex DTO object

final LinkedInPersonalInfo? firstName;
  final LinkedInPersonalInfo? lastName;
  final LinkedInProfilePicture? profilePicture;
  final String? userId;
  final String? localizedFirstName;
  final String? localizedLastName;
  LinkedInProfileEmail? email;
  late LinkedInTokenObject token;

We will have something like

  final String? name;
  final String? lastName;
  final String? givenName;
  final bool? isEmailVerified;
  final String? sub;
  final String? email;
  final String? picture;
  final LinkedInPreferredLocal? locale;

This is ofc much more readable and easier to access info, but will also mean introducing breaking changes.

@d3xt3r2909
Copy link
Owner

d3xt3r2909 commented Nov 15, 2023

Hey, me once again.

I publish Prerelease 3.0.0-beta.1 of this package.

Would love to hear feedback from you after trying ;]

Thanks again @dzab5 for opening an issue. Migration guid is inside readme.md and small part inside change log, but ofc if you have any doubts let me know.

@d3xt3r2909 d3xt3r2909 changed the title [BUG] Dealing with new scopes after deprecation of Sign in with linkedin Removing Sign in with LinkedIn and introducing OpenID Nov 15, 2023
@d3xt3r2909
Copy link
Owner

Hey @dzab5 did you had chance to test it?

Thanks

@RAWAN244

This comment was marked as off-topic.

@d3xt3r2909
Copy link
Owner

Hey @RAWAN244,

Issue that you are facing is not (at least) shouldn't be connected with this issue and PR. Could you please open new issue with a bit more details (step to reproduce, video maybe, which version of library ur using etc).

Thanks

@Thelm76

This comment was marked as off-topic.

@d3xt3r2909
Copy link
Owner

d3xt3r2909 commented Mar 18, 2024

Hi @Thelm76 I am not sure how your comment and PR are connected with currently opened issue? Marking it as hide but if I am wrong please let me know. Also if you still think that something is wrong please create new issue. Many thanks!

@d3xt3r2909
Copy link
Owner

Announcement: I am publishing version 3.0.0 of this library (not beta anymore) which means that library is converted to OpenID from version >= 3.0.0.

Thanks for reporting issue and please create new issue/s if something is wrong with this or any other release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FAQ List of questions that can be candidates for documentation post feature request !!!IMPORTANT!!! resolved
Projects
None yet
Development

No branches or pull requests

4 participants