Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission "how interesting is this" sort order #70

Closed
d4rken opened this issue Jul 20, 2022 · 10 comments
Closed

Permission "how interesting is this" sort order #70

d4rken opened this issue Jul 20, 2022 · 10 comments
Labels
enhancement New feature or request
Milestone

Comments

@d4rken
Copy link
Member

d4rken commented Jul 20, 2022

Permissions in app details are not well sorted, we should sort them.

Suggestion:

  • Primary sort order: GRANTED/DENIED/UNKNOWN
  • Secondary sort order: Interest level

The second sort will be based on a number that we manually give each of the known permissions. We create a sort order similar to how the system shows the permissions to create a familiar experience for the user.

@d4rken d4rken added the enhancement New feature or request label Jul 20, 2022
@d4rken
Copy link
Member Author

d4rken commented Jul 20, 2022

Hm, though the system sorts them by name, maybe we just need categories with a sort order and give permissions that the system also lists in the "permission manager" a common category.

@d4rken
Copy link
Member Author

d4rken commented Jul 20, 2022

enum class VisibilityCategory {
MAIN,
SECONDARY,
UNKNOWN
}

Give category MAIN to all of these:
Screenshot from 2022-07-20 21-43-45

@TheRealMystic
Copy link
Collaborator

Or should it be:

  1. Managed by User
  2. Managed by System

@TheRealMystic
Copy link
Collaborator

On my phone, I already see 690 entries in the Permissions Tab.

Out of these, only those 30 or so are controlled by the user. Rest everything is managed by the System itself.

@TheRealMystic
Copy link
Collaborator

Here are the permissions controllable by the user on a Samsung phone:

Special Access

Permissions Manager

Additional Permissions

@d4rken
Copy link
Member Author

d4rken commented Jul 23, 2022

Here are the permissions controllable by the user on a Samsung phone:

Special Access

Permissions Manager

Additional Permissions

Good, we need to map the "human readable name" to their ID now.
https://developer.android.com/reference/android/Manifest.permission

@d4rken d4rken added this to the v1.0.0 milestone Jul 27, 2022
@dragonGod97677
Copy link
Contributor

How about these for permission tab

Common: permissions in here are that can be seen on every app info settings, and the user can choose whether to allow the permission for an app or deny it

Uncommon: permissions in here are that scattered on the android settings, like accessibility, notification access, modify system settings, wifi control, and more. The user can choose whether to allow the permission for an app or deny it

User App/System defaults: These permissions are used by them to function properly, allowed by default and cannot be modified unless device is rooted or modifying the said app(s).

@TheRealMystic
Copy link
Collaborator

TheRealMystic commented Jul 28, 2022

@dragonGod97677

Common here is what @d4rken referred to as Primary.

Uncommon is what he referred to as Secondary.

Both of these categories are what I clubbed together as Managed by User, and pretty much the only permissions that are important (from a user perspective).

The rest of the permissions are not within user control (not without root) and probably shouldn't be tampered with either. As far as I understood, these are also necessary for the app to function properly without errors. Only users who fully understand these should touch them, and such users are a very small minority.

I have made my suggestions in #86 and #89. Do check them out and provide feedback.

@dragonGod97677
Copy link
Contributor

@dragonGod97677

Common here is what @d4rken referred to as Primary.

Uncommon is what he referred to as Secondary.

Both of these categories are what I clubbed together as Managed by User, and pretty much the only permissions that are important (from a user perspective).

The rest of the permissions are not within user control (not without root) and probably shouldn't be tampered with either. As far as I understood, these are also necessary for the app to function properly without errors. Only users who fully understand these should touch them, and such users are a very small minority.

I have made my suggestions in #86 and #89. Do check them out and provide feedback.

I didn't know there's names already to be used for sorting permissions 😅.

Oh well, all is good now

@d4rken
Copy link
Member Author

d4rken commented Jul 31, 2022

Adjusted for next release.

First sort order: Granted/Denied/Unknown
Second sort order: Known/Unknown permissions
Third sort order: Runtime permission, then special access, then everything else.

42db5d8

@d4rken d4rken closed this as completed Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants