Fix build fail caused by Glide #105
Conversation
There was a problem hiding this comment.
It's already part of the gradle file at https://github.com/bobheadxi/reddit-android-appstore/blob/9d26544ff6d75d123177a031e5623073afe93d32/app/build.gradle#L163.
|
The issue is that 4.0.0-SNAPSHOT is always the latest bleeding edge version, so depending on when the gradle cache is build, 4.0.0-SNAPSHOT is different then before. The solution is to replace |
| @@ -19,7 +20,7 @@ public void applyOptions(Context context, GlideBuilder builder) { | |||
| } | |||
|
|
|||
| @Override | |||
| public void registerComponents(Context context, Registry registry) { | |||
| public void registerComponents(Context context, Glide glide, Registry registry) { | |||
There was a problem hiding this comment.
This was a change recommended by Android Studio, although according to https://github.com/bumptech/glide/blob/master/library/src/main/java/com/bumptech/glide/module/GlideModule.java looks like GlideModule is slated to be removed for 4.0.0
bobheadxi
changed the title
This reverts commit a74a93a.
|
Ah oops, forgot to change the commit name |
Issues
#104
Changes
Temporarily fix build fail caused by Glide v4 update by updating implementation of
GlideConfigModule