Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Specify Javapoet version #121

Merged
merged 1 commit into from
Aug 8, 2017
Merged

Specify Javapoet version #121

merged 1 commit into from
Aug 8, 2017

Conversation

bobheadxi
Copy link
Collaborator

@bobheadxi bobheadxi commented Aug 7, 2017

See comment, this change resolves situations where GlideApp does not get generated

@bobheadxi bobheadxi merged commit 1a7bc38 into d4rken-org:dev Aug 8, 2017
@d4rken
Copy link
Member

d4rken commented Aug 8, 2017

What does this do?

@bobheadxi
Copy link
Collaborator Author

bobheadxi commented Aug 8, 2017

@d4rken It doesn't seem to be an issue with anyone else or Travis, but GlideApp was not generating for me despite rebuilds, etc. I looked around and a post somewhere mentioned that Dagger comes bundled with its own version of Javapoet and that it caused issues with Glide's annotationProcessor. So I added the compile and the GlideApp was generated. A bit odd.

Sorry about that, forgot to link it, the comment I made is here and the post about Javapoet is here

Now that I think about it annotationProcessor might have been more suitable than compile hm

@d4rken
Copy link
Member

d4rken commented Aug 8, 2017

Weird that this only affects you. Have you tried clearing your build cache and seeing if this persists?

When adding "workaround-code" I think it's good to also add a comment in code linking to an issue ticket with more details.

@bobheadxi
Copy link
Collaborator Author

I tried invalidating cache, removing the project entirely, clean/rebuild/make etc.

That is a good point, I will keep that in mind, definitely need to work on commenting. thank you

@bobheadxi bobheadxi deleted the pr-javapoet branch August 10, 2017 14:13
bobheadxi added a commit that referenced this pull request Sep 6, 2017
* Fixes GlideApp not being generated
bobheadxi added a commit that referenced this pull request Sep 6, 2017
bobheadxi added a commit that referenced this pull request Sep 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants