Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Fixes #142: Fix new AppDetails layout #143

Merged
merged 1 commit into from
Sep 2, 2017
Merged

Fixes #142: Fix new AppDetails layout #143

merged 1 commit into from
Sep 2, 2017

Conversation

bobheadxi
Copy link
Collaborator

@bobheadxi bobheadxi commented Sep 2, 2017

Issues

#142: After the redesigned AppDetails page from #131, relaunching Android Studio and rebuilding the app caused all sorts of weird things to happen

Changes

  • Better specification of margins, themes, etc. in layout file
  • Added bottom padding underneath the Description CardView to prevent Download FAB from obstructing description when in landscape or when description is very long, example:
    appdetailspatch

@bobheadxi bobheadxi merged commit 8964696 into d4rken-org:dev Sep 2, 2017
@bobheadxi bobheadxi deleted the pr/appdetailsfix branch September 2, 2017 15:22
bobheadxi added a commit that referenced this pull request Sep 6, 2017
* Better specification of margins, themes, etc. in layout file

* Added extra padding underneath the Description CardView
bobheadxi added a commit that referenced this pull request Sep 6, 2017
bobheadxi added a commit that referenced this pull request Sep 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants