Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Fixes #126: Option to Save Selected Tag Filters #147

Merged
merged 6 commits into from
Sep 6, 2017
Merged

Fixes #126: Option to Save Selected Tag Filters #147

merged 6 commits into from
Sep 6, 2017

Conversation

bobheadxi
Copy link
Collaborator

@bobheadxi bobheadxi commented Sep 5, 2017 •
edited
Loading

Issues

#126: Allow for the option to save selected Tag filters

Changes

  • Added new checkbox to enable tag filter saving under Settings -> Options
  • Certain strings renamed where appropriate
  • Some code cleanup

d4rken
d4rken reviewed Sep 5, 2017
View reviewed changes
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saving/Restoring, i.e. preference access shouldn't be part of a list adapter, better part of the fragment or even better abstracted away through the presenter. So the presenter has some kind of datasource for stored tags and just tells the fragment what to display.

@bobheadxi
Copy link
Collaborator Author

bobheadxi commented Sep 6, 2017 •
edited
Loading

commit fbc8804
Changes:

  • Inject SharedPreferences into AppListPresenter
  • Saving tags and getting saved tags handled in AppListPresenter upon attach/detach
  • Presenter calls Fragment which callsFilterListAdapter to restore saved tags
  • Presenter gets selected tags from Fragment to save tags

@d4rken Is this what you mean? Not not sure if passing information (the active tags) from Fragment to Presenter breaks any rules

d4rken
d4rken approved these changes Sep 6, 2017
View reviewed changes
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bobheadxi bobheadxi merged commit 602e4f1 into d4rken-org:dev Sep 6, 2017
@bobheadxi bobheadxi deleted the pr/save-selected-tags branch September 6, 2017 14:33
@bobheadxi
Copy link
Collaborator Author

@d4rken I think that's it for v0.8.0, I'll set up for a release?

bobheadxi added a commit that referenced this pull request Sep 6, 2017
@bobheadxi
Fixes #126: Option to Save Selected Tag Filters (#147)
0bd53fb 
* New option in Settings to toggle filter saving

* Some English strings updated

* Improved code legibility in a few places
bobheadxi added a commit that referenced this pull request Sep 6, 2017
@bobheadxi
Revert "Fixes #126: Option to Save Selected Tag Filters (#147)"
3db6b1f 
This reverts commit 0bd53fb.
bobheadxi added a commit that referenced this pull request Sep 6, 2017
@bobheadxi
Revert "Fixes #126: Option to Save Selected Tag Filters (#147)"
5b2b5a4 
This reverts commit 0bd53fb.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d4rken d4rken d4rken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bobheadxi @d4rken