Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Issue #108: Adding German translations #156

Merged
merged 1 commit into from Oct 7, 2017
Merged

Issue #108: Adding German translations #156

merged 1 commit into from Oct 7, 2017

Conversation

crud3
Copy link
Contributor

@crud3 crud3 commented Oct 7, 2017

I have added the missing German translations mentioned in #108 and also translated the submitapp string.

Some Remarks / Questions:

  • I could also translate the themes strings ("Light", "Dark") if you want, but I personally think that would sound very forced/unnatural. Many German Apps/Programs just use "Light" and "Dark" and don't translate it.
  • I also copied the "themesValues" array from the values.xml because it appeared in the error log. Is that correct or should I remove it?

@bobheadxi
Copy link
Collaborator

Thanks! 🎊 If you don't think the themes need translating they should be fine. themesValues probably shows up on the errors simply because they are absent, but adding them should be harmless

@bobheadxi bobheadxi merged commit 036f03a into d4rken-org:dev Oct 7, 2017
@crud3 crud3 deleted the 108-german-translation branch October 14, 2017 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants