Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Choose filter] function #1472

Open
Edfgdz opened this issue Jan 23, 2018 · 7 comments
Open

[Choose filter] function #1472

Edfgdz opened this issue Jan 23, 2018 · 7 comments

Comments

@Edfgdz
Copy link

Edfgdz commented Jan 23, 2018

Want to add fuction named[Choose filter]
This is usercase.
Supposed there is a Userfilter A in SystemCleaner.When i choose new files SD Maid will creat a new filter named B and it will add files basepathes to filter B.
But sometime i want to add file basepathes to Userfilter A,not creat a new filter to contain them.It means i must copy basepathes first then into Filter B to paste them.
So i want to add [Choose (Existing) Filter]to directly put basepathes into Userfilter A for skipping copy and paste action.
How do you consider it?

@d4rken d4rken added this to the Next Tasks milestone Jan 23, 2018
@d4rken
Copy link
Member

d4rken commented Jan 23, 2018

Some thoughts:

What if the target filter has options like "DIRECTORY", but the pathes we add are files? Do we just remove the DIR/FILE restriction?

This could also be dangerous, if we remove restrictions it could match too much without the user noticing...

But the user "should" check the results after adding new pathes, so maybe we just ignore edge cases for now...

When selecting "Add to SystemCleaner" we show a dialog that contains the existing filters and a NEW button...

@Edfgdz
Copy link
Author

Edfgdz commented Jan 23, 2018

Why it could match too much without restriction?
In fact,usually i wont check the result after scan.

@Edfgdz
Copy link
Author

Edfgdz commented Jan 23, 2018

If there is conflict between restriction and added pathes,can sd maid show a pop up to remind user of it?

@d4rken
Copy link
Member

d4rken commented Jan 23, 2018

Everything is possible, the question is at which point does it get too complicated or too much work for a single feature.

@Edfgdz
Copy link
Author

Edfgdz commented Jan 24, 2018

User may know what restrictions are in each filters.
Generally,when i want to add pathes to some-filter,i know which filters have restriction because those are special filters and i will avoid them for select filters without restriction in them.
@d4rken

@Edfgdz Edfgdz closed this as completed Jan 29, 2018
@Edfgdz Edfgdz reopened this Jan 29, 2018
@Edfgdz
Copy link
Author

Edfgdz commented Feb 2, 2018

When user choose a filter,user can go into that filter editing page to add new file/folder pathes,so they can see restrictions in that filter.
Can this solve the problem of restriction conflicts?

@Edfgdz
Copy link
Author

Edfgdz commented Jun 27, 2020

I am not sure if you think this problem too complexly, normally users should know how they set the userfilters themselves, it means when adding paths to existing filters, they should know which filters have directory /file restriction and which have empty or not empty restriction etc.

So should we care about this problem?

@d4rken d4rken modified the milestones: Next tasks, SD Maid 2/SE Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants