Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clutterreport: /data/app/FelipeLeite.Greight-1 (FP) #1815

Closed
garmendes opened this issue Jul 4, 2018 · 15 comments
Closed

Clutterreport: /data/app/FelipeLeite.Greight-1 (FP) #1815

garmendes opened this issue Jul 4, 2018 · 15 comments

Comments

@garmendes
Copy link

Target

Target: /data/app/FelipeLeite.Greight-1
Prefix-free: FelipeLeite.Greight-1
Path-prefix: /data/app/
Type: DIRECTORY
Location: APP_APP
Current keeper state: false
Suggested keeper state: true

Suggested owners

Appname: Loja de temas
Packagename: com.samsung.android.themestore
Version: 1.03.22(20160524) (10322)

Current owners

None

SD Maid

Version: 4.10.13 (41013)

Device

Fingerprint: samsung/o7ltedd/o7lte:6.0.1/MMB29M/G600FYVJU1BPL3:user/release-keys

@d4rken
Copy link
Member

d4rken commented Jul 5, 2018

Is this the same issue as #1813 ?

@d4rken d4rken added this to the Next Tasks milestone Jul 5, 2018
@SuperSandro2000
Copy link

SuperSandro2000 commented Jul 5, 2018

Not exactly. As far as I can tell this is an Samsung Theme Store Theme. I am going to do some research.
Edit: It is a similar issue to #1813 . Gonna post some more information over there.

@garmendes
Copy link
Author

As far as I can tell this is an Samsung Theme Store Theme.

Exactly. Every theme is removed in the current rules. After reboot they appear as broken in the apps list, but they should never appear here, as they are "special apps".

What info do you need?

@SuperSandro2000
Copy link

I provided quite a few infos in #1813. Should be fixes together with the substratum issues I would guess.

@d4rken
Copy link
Member

d4rken commented Jul 7, 2018

Does this theming technique have the same target_package field as #1813??

@SuperSandro2000
Copy link

As you can see here not exactly. Samsung does it different. The theme requests a permission and has a field that requests some "features" eg: <uses-feature d1p1:name="samsung.theme.wallpaper"/>

@d4rken
Copy link
Member

d4rken commented Jul 7, 2018

By "not exactly" you mean that not all Samsung themes have it? Do some have it? I guess we have to differentiate between user apps being themed and system components being themed?

@SuperSandro2000
Copy link

SuperSandro2000 commented Jul 7, 2018

I mean that Samsung handles stuff differently than substratum.

All Samsung themes have this permission com.samsung.android.permission.SAMSUNG_OVERLAY_* and one ore more of these Meta data fields <uses-feature d1p1:name="samsung.theme.*"/>

@d4rken
Copy link
Member

d4rken commented Jul 7, 2018

So I think this will be adressed by the soslution proposed in #1813 (comment)

I don't have a Samsung device to test this, @gagabs please send me a mail to test a preview version when I have implemented this so that we can confirm it works correctly.

@SuperSandro2000
Copy link

Suggested owners
Appname: Loja de temas
Packagename: com.samsung.android.themestore
Version: 1.03.22(20160524) (10322)

Just saying that this is technically not correct as theme store does not own the folder

@d4rken
Copy link
Member

d4rken commented Jul 9, 2018

Closed #1813

@d4rken d4rken closed this as completed Jul 9, 2018
@garmendes
Copy link
Author

Still present in 4.11.3 BETA

@garmendes
Copy link
Author

Possible related info: working Samsung's themes doesn't appear in any app list, only the broken ones

@SuperSandro2000
Copy link

This issue is about the apks. The issue with private data is located here #1842 and being looked at.

@d4rken
Copy link
Member

d4rken commented Jul 11, 2018

@gagabs Please post the screenshot in #1842 and also elaborate on what you mean "only the broken ones"? 🤗

That system:ui is also uncommon, maybe worth a ticket too if you think this is a false positive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants