This repository has been archived by the owner on May 29, 2024. It is now read-only.
Make sure events are returned in the correct sequence order. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents "Expected an event with sequence number N." exceptions.
|
oh shit that was a good catch!! thanks, man! 👍 ⚡ |
|
I'll see to it that your fix gets released immediately |
|
Much appreciated 😄 |
|
yeah - that must have bothered you 😨 |
|
it's out in 0.67.1 as soon as the build server finishes running tests and packing |
|
it's out now 😁 thanks 👍 |
|
That was super fast. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents
Expected an event with sequence number N.exceptions. I used to get these exceptions in about 3-5% of the emitted commands. This seems to fix it.Here's a more detailed explanation of my issue: http://stackoverflow.com/questions/36487655/cirqus-expected-an-event-with-sequence-number-0-exception