Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lodash dependency #1

Closed
mlabrum opened this issue Feb 20, 2018 · 0 comments · Fixed by #2
Closed

Lodash dependency #1

mlabrum opened this issue Feb 20, 2018 · 0 comments · Fixed by #2

Comments

@mlabrum
Copy link
Contributor

mlabrum commented Feb 20, 2018

Hey,

Thanks for creating this library.

I'm wondering why you included the lodash dependency, It doesn't look like https://github.com/d8660091/react-popper/blob/master/src/index.js uses it at all, can this be removed? or replaced with lodash-es if it's required

Cheers,

@mlabrum mlabrum mentioned this issue Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant