Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLD uri mismatch #1

Closed
clottes opened this issue Mar 10, 2014 · 4 comments
Closed

TLD uri mismatch #1

clottes opened this issue Mar 10, 2014 · 4 comments

Comments

@clottes
Copy link
Contributor

clottes commented Mar 10, 2014

the packtag.tld (inside jar version 3.9) uri declaration refers to:
https://github.com/d8bitr/packtag

which results in the following error:
The absolute uri: http://packtag.sf.net cannot be resolved in either web.xml or the jar files deployed with this application

Switching taglib declaration to:
<%@ taglib uri="https://github.com/d8bitr/packtag" prefix="pack" %> will fix this,
but then it's inconsistent with the releases location in your repository, which is under:
net/sf/pcaktag as well as the groupId and everything else points to "net.sf.packtag"

@galan
Copy link
Owner

galan commented Mar 22, 2014

Thanks for pointing this out, I have just released 3.10 which should have solved this

@galan galan closed this as completed Mar 22, 2014
@clottes
Copy link
Contributor Author

clottes commented Apr 16, 2014

Daniel,
I have been using LABJS for deferred javascript loading, using this in
conjunction with packtag had obviously created problems, as packtag always
creates the script tags....
On my branch I have created a attribute labjs to adjust for this and
print out in labjs loading style....

However I propose adding an attribute such as "tag" defaults to true,
but if false omits everything but the source filename as output.
(this way it would be supportable in any way possible, not just labjs).
Or perhaps we should call it onlySrc, and default to 'false'

let me know what you think and I'll clean up the code I did and change
it to an agreed upon functionality.

Sincerely,
Chris Lottes

On Sat, Mar 22, 2014 at 5:46 AM, Daniel Galán y Martins <
notifications@github.com> wrote:

Closed #1 #1.


Reply to this email directly or view it on GitHubhttps://github.com//issues/1
.

@galan
Copy link
Owner

galan commented Apr 23, 2014

Hi Chris, can you please create a new issue to keep things seperate? Beside of this it seems like an interesting use-case. Best Daniel

@galan
Copy link
Owner

galan commented Apr 24, 2014

Just in case you don't find the project, my user name changed, new project link is https://github.com/galan/packtag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants